Confirm closing game in prod

[voloder]

Description:

After accidentally pressing the back button on my mouse mid game, I got frustrated with the fact that there's no confirmation before the game closes abruptly

In this PR I have added confirmation, but only when the user is in an active game. It's disabled in dev mode to prevent annoyances with hot reload and debugging.

I hope this PR helps someone.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

ado1928

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Warning

Rate limit exceeded

@ryanbarlow97 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 8 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c4a12fe and 2615296.

📒 Files selected for processing (1)

• src/client/Main.ts (1 hunks)

Walkthrough

The PR enhances browser lifecycle event handling in the client by adding a development-mode guard to the beforeunload handler to prevent unintended page navigation when games are active, and introducing a pagehide handler to gracefully stop games when the page becomes hidden.

Changes

Cohort / File(s)	Summary
Browser Lifecycle Event Handlers src/client/Main.ts	Enhanced beforeunload event with event parameter and development-mode guard to prevent page unload when a game is active. Added new pagehide event handler that logs a message and stops the active game when the page is hidden.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify the development-mode guard logic is correct and doesn't interfere with intended unload behavior
• Confirm the pagehide handler executes reliably across browser contexts
• Check that gameStop is consistently set/cleared throughout the application lifecycle

Suggested reviewers

• evanpelle

Poem

🎮 When browsers close and pages fade away,
The game stops safely, come what may,
Dev mode flows free, production stays true,
Lifecycle events keep the session through! ✨

Pre-merge checks

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding confirmation when closing the game in production.
Description check	✅ Passed	The description is well-related to the changeset, explaining the motivation, implementation details, and testing approach.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[VariableVince]

@voloder Sorry but there are 2 PRs for this already, linked to issue #1877. This could mean your PR won't be accepted

[evanpelle]

I don't understand why these lines are necessary?

[evanpelle]

singpleplayer has a beforeunload hook to save the game, so just want to make sure they don't conflict.

[evanpelle]

When clicking the exit button in game, there is a prompt, will this cause duplicate prompts?

[github-actions]

This pull request is stale because it has been open for fourteen days with no activity. If you want to keep this pull request open, add a comment or update the branch.

[github-actions]

This pull request is stale because it has been open for fourteen days with no activity. If you want to keep this pull request open, add a comment or update the branch.

[Lavodan]

@voloder Are you still interested in finishing this PR up?

[iiamlewis]

Stale PR that is now orphaned. If anyone wants to pick this up, feel free!

[deshack]

Stale PR that is now orphaned. If anyone wants to pick this up, feel free!

I opened PR #2777. It's up-to-date with latest changes to main and takes a completely different approach.

[iiamlewis]

Stale PR that is now orphaned. If anyone wants to pick this up, feel free!

I opened PR #2777. It's up-to-date with latest changes to main and takes a completely different approach.

Amazing, I'll close this down