-
Notifications
You must be signed in to change notification settings - Fork 760
Added pause functionality for private multiplayer games #2657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
evanpelle
merged 12 commits into
openfrontio:main
from
YoussfeCantCode:pause-private-games
Dec 26, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1e2f877
Added pause functionality for private multiplayer games
YoussfeCantCode 24f7509
PauseOverlay changes
YoussfeCantCode 0e294bc
followed coderabbit suggestions
YoussfeCantCode c7357f1
Merge branch 'main' into pause-private-games
YoussfeCantCode 779ad4e
implementation data flow refactor
YoussfeCantCode f793682
removed remnant from previous integration and followed CodeRabbit's s…
YoussfeCantCode bad2b71
Merge branch 'main' into pause-private-games
YoussfeCantCode 877e5d6
refactor: Follow code review feedback for pause implementation
YoussfeCantCode c90ad49
Replace PauseOverlay with HeadsUpMessage for pause notifications
YoussfeCantCode 7540574
Merge branch 'main' into pause-private-games
YoussfeCantCode 37d7385
Merge branch 'main' into pause-private-games
YoussfeCantCode c0a417c
fix: Filter pause intents in replays and prevent intent stacking duri…
YoussfeCantCode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 632
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 91
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 5847
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 3568
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 94
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 1920
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 1343
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 94
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 685
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
# Look at how the game handles pause state during replay more completely cat -n src/core/execution/PauseExecution.tsRepository: openfrontio/OpenFrontIO
Length of output: 804
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 1935
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 243
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 3839
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 1570
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 2901
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 793
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 379
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 946
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 315
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 1660
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 49
Guard toggle_pause against replay or document the behavior.
The toggle_pause handler doesn't check for replay mode (lines 110-122), so if sent during replay, the intent is pushed to
this.intentsbut then discarded whenendTurn()replaces intents with archived replay intents (line 187). In singleplayer replay, pause should work since the replayer is the player, but the discarded intent meansPauseExecutionnever processes it.Either:
🤖 Prompt for AI Agents