-
Notifications
You must be signed in to change notification settings - Fork 753
Feat: Lemnos Map #2683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Lemnos Map #2683
Conversation
WalkthroughAdds a new map "Lemnos": localization entry, manifest and nation asset, registered in the game map enum and categories, client description, default player-counts, playlist weight, and map-generator registration. Changes
Sequence Diagram(s)(omitted — changes are additive registrations and data files without cross-component control-flow changes) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Playtested a number of times now and can confirm it is good fun, but also pretty hard against the AI nations! |
Tidwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to:
- Add
map-generator/assets/lemnos/info.jsonandimage.png. - Add lemnos to
map-generator/main.go. - Document your source to
CREDITS.md(make sure they have usable license)
|
Also, you might want to shave the size a bit. At 1630x2000 you're a little over the 3 million sq px suggested limit. |
Duwibi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The map looks very nice! Please also add in the image.png file and info.json file in map-generator.
|
As someone who ran Arma 3 communities for a long time, this gives nostalgia |
|
@Tidwell I added the files and made the updates in the @Duwibi Added it! @iiamlewis I sort of figured the venn diagrams for openfront enjoyer and arma player would intersect somewhere 🔥 |
evanpelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Description:
Introduces the Greek island, Lemnos, as a map. The island is both fun and challenging to play (because of the terrain and elevation) and this addition was inspired by Altis from the game Arma 3. The nation names are set based on the real landmarks, towns, and regions.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
bijx