Skip to content

Conversation

@bijx
Copy link
Contributor

@bijx bijx commented Dec 24, 2025

Description:

Introduces the Greek island, Lemnos, as a map. The island is both fun and challenging to play (because of the terrain and elevation) and this addition was inspired by Altis from the game Arma 3. The nation names are set based on the real landmarks, towns, and regions.

image image

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

bijx

@bijx bijx requested a review from a team as a code owner December 24, 2025 04:48
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 24, 2025

Walkthrough

Adds a new map "Lemnos": localization entry, manifest and nation asset, registered in the game map enum and categories, client description, default player-counts, playlist weight, and map-generator registration.

Changes

Cohort / File(s) Summary
Localization
resources/lang/en.json
Added "lemnos": "Lemnos" to the map localization object.
Map manifest & assets
resources/maps/lemnos/manifest.json, map-generator/assets/maps/lemnos/info.json
New manifest with dimensions/scaled variants and info.json listing 9 nations and the map name.
Game map types & categories
src/core/game/Game.ts
Added Lemnos = "Lemnos" to GameMapType and included it in mapCategories.regional.
Client descriptions
src/client/components/Maps.ts
Added Lemnos to the exported MapDescription mapping.
Default configuration
src/core/configuration/DefaultConfig.ts
Added Lemnos entry to numPlayersConfig with values [20, 15, 10].
Server playlist
src/server/MapPlaylist.ts
Added Lemnos to map frequency mapping with weight 3.
Map-generator registration
map-generator/main.go
Registered lemnos in the map generation registry.

Sequence Diagram(s)

(omitted — changes are additive registrations and data files without cross-component control-flow changes)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Add Svalmel #2600 — Adds a new map and touches the same enum, manifest, localization, config, and playlist surfaces.
  • Add New York City Map #2542 — Parallel map-add PR updating manifests, map assets, GameMapType, MapDescription, DefaultConfig, and MapPlaylist.
  • Add Achiran #2280 — Another PR that modifies the same map-related registries and files when adding a new map.

Suggested labels

Feature - Map

Suggested reviewers

  • evanpelle

Poem

🌊 A small isle added to the code,
Nine towns placed on a tiny node.
Lemnos sails into the map parade,
New games to start, new deals to be made. 🎉

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Feat: Lemnos Map' clearly and concisely summarizes the main change: introducing a new map for the Greek island Lemnos.
Description check ✅ Passed The description is directly related to the changeset, explaining the Lemnos map addition, its inspiration from Arma 3, nation naming, and including screenshots and confirmation of testing and translation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70e9dd9 and 61754df.

📒 Files selected for processing (2)
  • resources/lang/en.json
  • src/core/game/Game.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/core/game/Game.ts
🔇 Additional comments (1)
resources/lang/en.json (1)

246-247: LGTM! Localization entry added correctly.

The JSON syntax is valid, the format matches existing entries, and "Lemnos" is the appropriate English name for the map. The trailing comma on line 246 and the new entry on line 247 are both correct.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 24, 2025
@bijx
Copy link
Contributor Author

bijx commented Dec 24, 2025

Playtested a number of times now and can confirm it is good fun, but also pretty hard against the AI nations!

Copy link
Contributor

@Tidwell Tidwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to:

  • Add map-generator/assets/lemnos/ info.json and image.png.
  • Add lemnos to map-generator/main.go.
  • Document your source to CREDITS.md (make sure they have usable license)

@Tidwell
Copy link
Contributor

Tidwell commented Dec 24, 2025

Also, you might want to shave the size a bit. At 1630x2000 you're a little over the 3 million sq px suggested limit.

Copy link
Contributor

@Duwibi Duwibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The map looks very nice! Please also add in the image.png file and info.json file in map-generator.

@iiamlewis iiamlewis added the Maps A new map, or adjustments to an existing map itself, its json, etc, label Dec 24, 2025
@iiamlewis iiamlewis added this to the v29 milestone Dec 24, 2025
@iiamlewis
Copy link
Contributor

As someone who ran Arma 3 communities for a long time, this gives nostalgia

@bijx
Copy link
Contributor Author

bijx commented Dec 24, 2025

@Tidwell I added the files and made the updates in the map-generator, hope that all looks good 👍 I also reduced the map size to 2.4M (1750x1420)

@Duwibi Added it!

@iiamlewis I sort of figured the venn diagrams for openfront enjoyer and arma player would intersect somewhere 🔥

@bijx bijx requested review from Duwibi and Tidwell December 24, 2025 16:23
coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 24, 2025
Copy link
Collaborator

@evanpelle evanpelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@evanpelle evanpelle merged commit 677a17d into openfrontio:main Dec 26, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Development to Complete in OpenFront Release Management Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maps A new map, or adjustments to an existing map itself, its json, etc,

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

5 participants