-
Notifications
You must be signed in to change notification settings - Fork 777
Very small UI fix 🔧 #2862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very small UI fix 🔧 #2862
Conversation
WalkthroughUpdated map naming and playlist frequency: the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/core/game/Game.ts (1)
72-119: Breaking change confirmed: enum value rename will reject persisted data.The
GameMapType.DidierFrancevalue change from"Didier (France)"to"Didier France"breaks validation for any stored or transmitted config containing the old value.The
z.enum(GameMapType)schema inGameConfigSchemavalidates game configs sent between client and server. If any localStorage, saved games, URLs, or server responses contain the old value, validation will fail after deploy.Recommend backwards compat: Accept both old and new values on input, normalize to the new enum value. This allows reading legacy data without breaking existing clients or servers.
Also note:
src/client/components/Maps.tshasMapDescriptionwith the old display name"Didier (France)"andresources/maps/didierfrance/manifest.jsonretains the old name—both appear to need updating for consistency with the enum value.
Description:
Didier map name had a little UI problem.
And unrelated change: Because Lewis today said "it should be super low" I turned down the frequency of this map from 2 to 1.
Previous:
Fixed:
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
FloPinguin