Skip to content

Conversation

@FloPinguin
Copy link
Contributor

@FloPinguin FloPinguin commented Jan 11, 2026

Description:

Didier map name had a little UI problem.

And unrelated change: Because Lewis today said "it should be super low" I turned down the frequency of this map from 2 to 1.

Previous:

image2

Fixed:

image

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

FloPinguin

@FloPinguin FloPinguin added this to the v29 milestone Jan 11, 2026
@FloPinguin FloPinguin requested a review from a team as a code owner January 11, 2026 02:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 11, 2026

Walkthrough

Updated map naming and playlist frequency: the GameMapType.DidierFrance enum label changed from "Didier (France)" to "Didier France", and the Didier France map frequency in MapPlaylist was reduced from 2 to 1.

Changes

Cohort / File(s) Summary
Map enum label
src/core/game/Game.ts
Changed GameMapType.DidierFrance value from "Didier (France)" to "Didier France" (string only).
Map playlist frequency
src/server/MapPlaylist.ts
Lowered the frequency/count for the Didier France map from 2 to 1 in the playlist generation mapping.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Feature - Backend, Maps

Suggested reviewers

  • evanpelle
  • scottanderson

Poem

🗺️ A parenthesis flew away,
Didier France steps into day,
Frequency trimmed, its turn to play,
Small edits guide the map’s new way. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title "Very small UI fix" is vague and generic, using non-descriptive terms that don't clearly convey the specific changes (Didier map name fix and frequency reduction). Consider a more specific title like "Fix Didier map name format and reduce playlist frequency" to clearly describe the main changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, explaining the UI problem fix and the frequency reduction, with supporting screenshots and confirmation of testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 419edda and be2c65a.

📒 Files selected for processing (1)
  • src/server/MapPlaylist.ts
🔇 Additional comments (1)
src/server/MapPlaylist.ts (1)

64-64: Frequency change is correct and type-safe.

The change from 2 to 1 is clean. The enum key DidierFrance is properly defined in GameMapType and correctly used in the frequency object as a GameMapName key type. No type issues.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/core/game/Game.ts (1)

72-119: Breaking change confirmed: enum value rename will reject persisted data.

The GameMapType.DidierFrance value change from "Didier (France)" to "Didier France" breaks validation for any stored or transmitted config containing the old value.

The z.enum(GameMapType) schema in GameConfigSchema validates game configs sent between client and server. If any localStorage, saved games, URLs, or server responses contain the old value, validation will fail after deploy.

Recommend backwards compat: Accept both old and new values on input, normalize to the new enum value. This allows reading legacy data without breaking existing clients or servers.

Also note: src/client/components/Maps.ts has MapDescription with the old display name "Didier (France)" and resources/maps/didierfrance/manifest.json retains the old name—both appear to need updating for consistency with the enum value.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eaf77cd and 419edda.

📒 Files selected for processing (1)
  • src/core/game/Game.ts

coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 11, 2026
@evanpelle evanpelle merged commit e130574 into openfrontio:main Jan 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants