Skip to content

Conversation

@OlivaresDarian
Copy link

@OlivaresDarian OlivaresDarian commented Nov 26, 2025

Description

This modification allows the Iterated Fission Probability (IFP) method implemented by @JoffreyDorville to break down the effective delayed neutron fraction $\beta_{eff}$ tally by isotope. This extension of the IFP method enables deeper analyses in reactor physics.

In practice, the IFP tally stores certain ancestor information to compute adjoint-weighted tallies. This adaptation follows the same principle but also records the isotope that generated each delayed neutron. It slightly increases both memory use and computation time.

To use it, you simply need to define a list of nuclides in $\texttt{beta-num-tally.nuclides = [...]}$.

Fixes #3605

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten
Copy link
Contributor

GuySten commented Nov 27, 2025

You should run clang format (version 15) on cpp source files for CI to successfully run.

@OlivaresDarian
Copy link
Author

You should run clang format (version 15) on cpp source files for CI to successfully run.

Thanks @GuySten for your help

@GuySten
Copy link
Contributor

GuySten commented Nov 27, 2025

I think you accidentally removed src/output.cpp and its header.
You should watch closely the "files changed" tab of this PR.
A change in 47 files seems too much for a feature of this scope.

@OlivaresDarian
Copy link
Author

I think you accidentally removed src/output.cpp and its header. You should watch closely the "files changed" tab of this PR. A change in 47 files seems too much for a feature of this scope.

You're right. I already restored the output.* files. From the 47 changes, more than 27 are related to tests modifications because we added a new variable to the Particle object. The current version passes all tests in local.

@GuySten
Copy link
Contributor

GuySten commented Nov 28, 2025

But you also added new files (I think by mistake).
Edit:
You can find them by the green plus in the files tab of this PR.

Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
OlivaresDarian and others added 3 commits December 11, 2025 12:01
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
OlivaresDarian and others added 6 commits December 11, 2025 12:28
…age to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@GuySten GuySten removed the Merging Soon PR will be merged in < 24 hrs if no further comments are made. label Dec 13, 2025
@GuySten
Copy link
Contributor

GuySten commented Jan 10, 2026

I've noticed that this feature does not support "total" nuclide. I will submit a fix soon.

Copy link
Contributor

@GuySten GuySten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #3719 is merged I intend to simplify this PR as well.

@GuySten
Copy link
Contributor

GuySten commented Jan 14, 2026

I simplified this PR further.
@OlivaresDarian, you are invited to give feedback.

Copy link
Contributor

@GuySten GuySten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I broke something. I will try to fix this soon.

@GuySten
Copy link
Contributor

GuySten commented Jan 14, 2026

I intend to update this PR once #3728 is merged.

Copy link
Contributor

@GuySten GuySten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should wait a bit to #3728.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nuclide filter for IFP method

4 participants