-
Notifications
You must be signed in to change notification settings - Fork 596
Delayed neutron fraction by isotope with IFP method #3659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
You should run clang format (version 15) on cpp source files for CI to successfully run. |
Thanks @GuySten for your help |
|
I think you accidentally removed src/output.cpp and its header. |
You're right. I already restored the output.* files. From the 47 changes, more than 27 are related to tests modifications because we added a new variable to the Particle object. The current version passes all tests in local. |
|
But you also added new files (I think by mistake). |
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
…age to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
I've noticed that this feature does not support "total" nuclide. I will submit a fix soon. |
GuySten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #3719 is merged I intend to simplify this PR as well.
|
I simplified this PR further. |
GuySten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently I broke something. I will try to fix this soon.
|
I intend to update this PR once #3728 is merged. |
GuySten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should wait a bit to #3728.
Description
This modification allows the Iterated Fission Probability (IFP) method implemented by @JoffreyDorville to break down the effective delayed neutron fraction$\beta_{eff}$ tally by isotope. This extension of the IFP method enables deeper analyses in reactor physics.
In practice, the IFP tally stores certain ancestor information to compute adjoint-weighted tallies. This adaptation follows the same principle but also records the isotope that generated each delayed neutron. It slightly increases both memory use and computation time.
To use it, you simply need to define a list of nuclides in$\texttt{beta-num-tally.nuclides = [...]}$ .
Fixes #3605
Checklist