Add IsValidWeapon native (#1009)#1011
Open
shierru wants to merge 2 commits intoopenmultiplayer:masterfrom
Open
Add IsValidWeapon native (#1009)#1011shierru wants to merge 2 commits intoopenmultiplayer:masterfrom
shierru wants to merge 2 commits intoopenmultiplayer:masterfrom
Conversation
Contributor
|
This is an incorrect check for the validity of weapons because there are no weapons that have an ID (19, 20, 21, 47, 48, 52) |
Contributor
It's not weapons, it's damage reasons. Moreover 19-21 aren't valid both as weapons or reasons |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately I haven't figured out how to properly make the changes in the SDK.
I hope you can help me :)