Implement timer's (set interval & pause/resume)#1087
Open
NoPressF wants to merge 1 commit intoopenmultiplayer:masterfrom
Open
Implement timer's (set interval & pause/resume)#1087NoPressF wants to merge 1 commit intoopenmultiplayer:masterfrom
NoPressF wants to merge 1 commit intoopenmultiplayer:masterfrom
Conversation
Member
|
You must create a pull request in https://github.com/openmultiplayer/open.mp-sdk for your fork of SDK repository, because right now this PR is pointing to a commit hash that doesn't exist in our own SDK repository, it's only in yours. Also you shouldn't add functions randomly in the middle of the virtual table (in ITimer in this example), new ones must be added to the end, after last virtual function. So this way we're not breaking ABI compatibility even more. |
Contributor
Author
Contributor
Author
|
@AmyrAhmady what about that? |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.