Conversation
|
Alex Cole seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Hual
reviewed
Jan 1, 2024
| }; | ||
|
|
||
| /// The player's name status returned when updating their name | ||
| enum EPlayerNameStatus |
Collaborator
There was a problem hiding this comment.
This isn't really a game type
Collaborator
Author
There was a problem hiding this comment.
True, a better name is probably required. They're more just generic structs and enums, but I hate the filename structs.hpp or similar, it doesn't tell you anything.
Collaborator
There was a problem hiding this comment.
player_types.hpp or player_structs.hpp?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some missing headers, and split the generic definitions for things like fighting styles and weapon slots out from the "IPlayer" structure file.