Skip to content

UseLombokGetter recipe: fix IndexOutOfBoundsException that occurs when visiting record compact constructor method #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 2 commits into from
Dec 11, 2025
Merged

UseLombokGetter recipe: fix IndexOutOfBoundsException that occurs when visiting record compact constructor method #956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0c4829
fix IndexOutOfBoundsException
zakaria-shahen Dec 11, 2025
758248f
fix typo
zakaria-shahen Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import org.jspecify.annotations.Nullable;
import org.openrewrite.Cursor;
import org.openrewrite.internal.StringUtils;
import org.openrewrite.java.marker.CompactConstructor;
import org.openrewrite.java.tree.Expression;
import org.openrewrite.java.tree.Flag;
import org.openrewrite.java.tree.J;
Expand All @@ -38,7 +39,7 @@ static boolean isGetter(Cursor cursor) {
return false;
}
// Check signature: no parameters
if (!(method.getParameters().get(0) instanceof J.Empty) || method.getReturnTypeExpression() == null) {
if (method.getMarkers().findFirst(CompactConstructor.class).isPresent() || !(method.getParameters().get(0) instanceof J.Empty) || method.getReturnTypeExpression() == null) {
return false;
}
// Check body: just a return statement
Expand Down
17 changes: 17 additions & 0 deletions src/test/java/org/openrewrite/java/migrate/lombok/UseLombokGetterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,23 @@ public int getFoo() {
);
}

@Test
void noChangeRecordWithCompactConstructor() {
rewriteRun(// language=java
java(
"""
public record Foo(String id) {
public Foo {
if (id == null || id.isBlank()) {
throw new IllegalArgumentException("ID cannot be null or blank");
}
}
}
"""
)
);
}

@Issue("https://github.com/openrewrite/rewrite/issues/5015")
@Test
void addOnMethodArgIfAnnotated() {
Expand Down