Skip to content

Conversation

@nielsdebruin
Copy link
Contributor

@nielsdebruin nielsdebruin commented Dec 16, 2024

What's changed?

This PR adds the initial version of the TabAndIndentsVisitor, based on its Java equivalent.

What's your motivation?

Get feedback on the desired behavior of the visitor before implementation.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@knutwannheden

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@nielsdebruin nielsdebruin added the enhancement New feature or request label Dec 16, 2024
@nielsdebruin nielsdebruin self-assigned this Dec 16, 2024
@nielsdebruin nielsdebruin mentioned this pull request Dec 30, 2024
7 tasks
@nielsdebruin nielsdebruin changed the title Initial test cases for tabs and indents visitor Tabs and Indents visitor Jan 9, 2025
@nielsdebruin nielsdebruin marked this pull request as ready for review January 9, 2025 11:01
@knutwannheden knutwannheden merged commit d6ef897 into main Jan 9, 2025
1 check passed
@knutwannheden knutwannheden deleted the autoformat/tabs-and-indents branch January 9, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants