Skip to content

Conversation

@knutwannheden
Copy link
Contributor

No description provided.

Comment on lines +18 to -13
requires-python = ">=3.12, <4"

[tool.poetry.dependencies]
python = ">=3.9"
pytest = "^8.3.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were standardizing around 3.9 for some reason that now escapes me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I accidentally used 3.12 API to parse f-strings. As soon as we have a customer requiring an older Python interpreter, I will try to fix that.

@zieka
Copy link
Member

zieka commented Dec 17, 2024

I am running into name space collisions when running test because rewrite module is overloaded:

    from rewrite import InMemoryExecutionContext, ParserInput, ParserBuilder, random_id, ParseError, ParseExceptionResult, \
E   ImportError: cannot import name 'InMemoryExecutionContext' from 'rewrite' (unknown location)

If I change the imports to rewrite_remote and link to my local project then tests go form 60 errors (imports) to 1 error (unrelated to imports)

@timtebeek
Copy link
Member

Would this workflow need to be changed as well?

uses: snok/install-poetry@v1

@knutwannheden
Copy link
Contributor Author

Tests actually passed for me, but the IDE displays errors on imports, which I don't understand.

@knutwannheden knutwannheden merged commit 27c6407 into main Dec 17, 2024
1 check passed
@knutwannheden knutwannheden deleted the uv branch December 17, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants