NO-JIRA: Fix documentation inconsistencies with actual code #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CLAUDE.md: Fix kcli vars filename, remove non-existent kcli/ directory references - helpers/README.md: Add missing code block closure - README-external-host.md: Fix vars sample filename - README-kcli.md: Fix defaults path, ocp_version, ocp_tag, ksushy_port values - proxy-setup/README.md: Clarify proxy_user is auto-detected - install-dev/README.md: Fix method variable docs and task structure - kcli-install/README.md: Fix defaults file link path 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@fonta-rh: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fonta-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The task was using `|| true` which hid failures when adding local SSH keys to cluster VMs, causing ProxyJump connections to fail with "Permission denied". Now properly fails with retries and shows results. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
When starting a fencing topology cluster, ensure the BMC simulator is running so STONITH fencing works properly. Supports both dev-scripts (sushy-tools container) and kcli (ksushy systemd service) deployments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The ssh-add -L command returns exit code 0 even when it outputs "The agent has no identities", causing garbage to be added to authorized_keys. Now filters out error messages and validates the key format before propagating. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix documentation inconsistencies and remove old kcli dev instructions
Fix SSH key propagation to cluster VMs that was failing silently due to || true, causing ProxyJump connections to fail with "Permission denied"
Start sushy-tools BMC simulator automatically on startup-cluster for fencing topology clusters (supports both dev-scripts and kcli deployments)