Skip to content

WIP: Add support for passing pre-mirrored images to appliance #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rwsu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Add support for passing pre-mirrored images to appliance #1830

rwsu wants to merge 1 commit into from

Conversation

@rwsu
Copy link
Contributor

@rwsu rwsu commented Dec 19, 2025

  • Add AGENT_OVE_BUILD_METHOD to control OVE ISO build method (script vs container)
  • Prepare registry directory structure for appliance in 04_agent_prepare_release.sh
  • Update 06_agent_create_cluster.sh to support both build methods
  • Both methods now extract agent-iso-builder source and pass mirror-path arguments

🤖 Generated with Claude Code

Assisted-by: Claude Sonnet 4.5 noreply@anthropic.com

@rwsu
WIP: Add support for passing pre-mirrored images to appliance
9a04668 
- Add AGENT_OVE_BUILD_METHOD to control OVE ISO build method (script vs container)
- Prepare registry directory structure for appliance in 04_agent_prepare_release.sh
- Update 06_agent_create_cluster.sh to support both build methods
- Both methods now extract agent-iso-builder source and pass mirror-path arguments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2025
@openshift-ci openshift-ci bot requested review from celebdor and zaneb December 19, 2025 23:42
@openshift-ci
Copy link

openshift-ci bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pawanpinjarkar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2025

@rwsu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 9a04668 link false /test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@zaneb zaneb Awaiting requested review from zaneb

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rwsu