Skip to content

[WIP]just for build pr No overlay mode resolved #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
zhaozhanqi wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP]just for build pr No overlay mode resolved #2636

zhaozhanqi wants to merge 2 commits into from

Conversation

@zhaozhanqi
Copy link

@zhaozhanqi zhaozhanqi commented Dec 24, 2025

No description provided.

@ricky-rav
Add API support and FeatureGate for OVN-Kubernetes no-overlay mode
0a87dc5 
This commit introduces API changes to support OVN-Kubernetes no-overlay mode for the default network,
where the cluster default network operates without overlay encapsulation (Geneve).

API changes (operator.openshift.io/v1):
- Added defaultNetworkTransport field to OVNKubernetesConfig (NoOverlay or Geneve)
- Added defaultNetworkNoOverlayOptions with outboundSNAT and routing configuration
- Added bgpManagedConfig for BGP configuration when routing is managed
- All no-overlay fields are immutable after cluster creation

Added feature gate (TechPreviewNoUpgrade) for NoOverlayMode within the Networking/ovn-kubernetes component.

Ran these commands to update autogenerated source files:
$ hack/update-codegen-crds.sh
$ hack/update-swagger-docs.sh
$ hack/update-payload-featuregates.sh

Openshift enhancement for this feature: openshift/enhancements#1859

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 24, 2025

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 24, 2025

Hello @zhaozhanqi! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai
Copy link

coderabbitai bot commented Dec 24, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhaozhanqi
Merge master into PR openshift#2537: Resolve conflict in features.go
5cb2732 
Resolved merge conflict between FeatureGateNoOverlayMode (from PR openshift#2537)
and FeatureGateNetworkConnect (from master). Both feature gates are now
included in the features.go file.
@zhaozhanqi zhaozhanqi force-pushed the no-overlay-mode-resolved branch from 37706f2 to 5cb2732 Compare December 24, 2025 01:45
@zhaozhanqi zhaozhanqi marked this pull request as draft December 24, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven Awaiting requested review from everettraven

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhaozhanqi @openshift-ci-robot @ricky-rav