Skip to content

Conversation

@vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Jan 8, 2026

SPLAT-2603

Changes

  • Modified the AWS dedicated host validation pattern to include older deprecated host id pattern of 8 alphanumeric

Notes

CodeRabbit in a separate PR had found that AWS has two patterns for this. It seems this pattern for 8 alphanumeric is an older deprecated ID format that was changed in 2018. We are updating our logic just in case some customer still owns one of these older instances and wants to try to use it with OCP.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2026

@vr4manta: This pull request references SPLAT-2603 which is a valid jira issue.

Details

In response to this:

SPLAT-2603

Changes

  • Modified the AWS dedicated host validation pattern to include older deprecated host id pattern of 8 alphanumeric

Notes

CodeRabbit in a separate PR had found that AWS has two patterns for this. It seems this pattern for 8 alphanumeric is an older deprecated ID format that was changed in 2018. We are updating our logic just in case some customer still owns one of these older instances and wants to try to use it with OCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2026

@vr4manta: This pull request references SPLAT-2603 which is a valid jira issue.

Details

In response to this:

SPLAT-2603

Changes

  • Modified the AWS dedicated host validation pattern to include older deprecated host id pattern of 8 alphanumeric

Notes

CodeRabbit in a separate PR had found that AWS has two patterns for this. It seems this pattern for 8 alphanumeric is an older deprecated ID format that was changed in 2018. We are updating our logic just in case some customer still owns one of these older instances and wants to try to use it with OCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from nrb and racheljpg January 8, 2026 18:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta
Copy link
Contributor Author

/assign @damdo

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

TY

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2026
@vr4manta
Copy link
Contributor Author

/verified by @vr4manta via manual and unit tests
This is being added to our tests as well.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 12, 2026
@openshift-ci-robot
Copy link
Contributor

@vr4manta: This PR has been marked as verified by @vr4manta via manual and unit tests.

Details

In response to this:

/verified by @vr4manta via manual and unit tests
This is being added to our tests as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b9e5793 into openshift:main Jan 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants