Skip to content

USHIFT-6430: Optimize service restart sequence in FeatureGates suite #5991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Dec 30, 2025
Merged

USHIFT-6430: Optimize service restart sequence in FeatureGates suite #5991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions test/suites/standard2/feature-gates.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,13 @@ Custom Feature Gates Are Passed To Kube APIServer
[Documentation] Check that custom feature gates specified in the MicroShift config are passed to and logged by the
... kube-apiserver. This test verifies that arbitrary feature gate values are correctly propagated from the
... MicroShift configuration to the kube-apiserver, regardless of whether the feature gates are valid or have any effect.
... Also verify that feature gate lock file is created when custom feature gates are configured.
... The lock file prevents upgrades and configuration changes when CustomNoUpgrade feature set is used.
[Setup] Setup Custom Feature Gates Test
Wait Until Keyword Succeeds 2 min 5 sec
... Pattern Should Appear In Log Output ${CURSOR} kube:feature-gates=.*TestFeatureEnabled=true
Wait Until Keyword Succeeds 2 min 5 sec
... Pattern Should Appear In Log Output ${CURSOR} kube:feature-gates=.*TestFeatureDisabled=false
[Teardown] Teardown Custom Feature Gates Test

Feature Gate Lock File Created With Custom Feature Gates
[Documentation] Verify that feature gate lock file is created when custom feature gates are configured.
... The lock file prevents upgrades and configuration changes when CustomNoUpgrade feature set is used.
[Setup] Setup Custom Feature Gates Test
Wait Until Keyword Succeeds 2 min 5 sec
... Feature Gate Lock File Should Exist
Feature Gate Lock File Should Contain Feature Gates CustomNoUpgrade TestFeatureEnabled
Expand All @@ -58,7 +54,6 @@ Feature Gate Config Change Blocked After Lock Created
[Documentation] Verify that changing feature gate config is blocked after lock file exists.
... MicroShift must refuse to start if feature gates change after CustomNoUpgrade is set.
[Setup] Setup Custom Feature Gates Test

Stop MicroShift
Drop In MicroShift Config ${DIFFERENT_FEATURE_GATES} 10-featuregates
Save Journal Cursor
Expand Down Expand Up @@ -89,7 +84,6 @@ Setup

Teardown
[Documentation] Test suite teardown
Restart MicroShift
Logout MicroShift Host
Remove Kubeconfig

Expand All @@ -102,16 +96,18 @@ Save Journal Cursor

Setup Custom Feature Gates Test
[Documentation] Drop in custom feature gates config and restart MicroShift
Stop MicroShift
Drop In MicroShift Config ${CUSTOM_FEATURE_GATES} 10-featuregates
Save Journal Cursor
Restart MicroShift
Start MicroShift
Feature Gate Lock File Should Exist

Teardown Custom Feature Gates Test
[Documentation] Remove custom feature gates config and restart MicroShift
Stop MicroShift
Remove Drop In MicroShift Config 10-featuregates
Remove Feature Gate Lock File If Exists
Restart MicroShift
Start MicroShift

Remove Feature Gate Lock File If Exists
[Documentation] Remove the feature gate lock file if it exists, for test cleanup
Expand Down