USHIFT-6498: Bump existing RHEL 10.0 tests to 10.2#6244
USHIFT-6498: Bump existing RHEL 10.0 tests to 10.2#6244vanhalenar wants to merge 4 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vanhalenar: This pull request references USHIFT-6498 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughDeleted a RHEL 10.0 test-agent Containerfile and migrated references from rhel100-* to rhel102-* across containerfiles and test scenario scripts, updating FROM lines, blueprint/image names, and an expected OS version where present. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test all |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vanhalenar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
vanhalenar
force-pushed
the
el10-test-bump
branch
from
1313c97 to
62cad9a
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@vanhalenar: This pull request references USHIFT-6498 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
test/scenarios-bootc/periodics/el102-src@standard-suite1.sh (1)
14-17:⚠️ Potential issue | 🟡 MinorChange
EXPECTED_OS_VERSIONfrom10.0to10.2.The other el102 scenario uses
10.2, matching the naming convention whereel102corresponds to RHEL 10.2 (consistent withel96→9.6pattern).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@test/scenarios-bootc/periodics/el102-src`@standard-suite1.sh around lines 14 - 17, In scenario_run_tests() update the EXPECTED_OS_VERSION variable value from "10.0" to "10.2" in the run_tests invocation (the --variable "EXPECTED_OS_VERSION:10.0" argument) so the el102 scenario matches the RHEL 10.2 naming convention used elsewhere.
🧹 Nitpick comments (1)
test/scenarios-bootc/releases/el102-lrel@optional.sh (1)
36-40: Redundant conditional.The
ifblock on lines 38-40 setsskip_argsto the same value already assigned on line 37. This appears to be leftover from when aarch64 had different skip logic.Suggested simplification
# TODO: Skip sriov on RHEL 10 until USHIFT-6400 is resolved. local skip_args="--skip sriov" - if [[ "${UNAME_M}" =~ aarch64 ]]; then - skip_args="--skip sriov" - fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@test/scenarios-bootc/releases/el102-lrel`@optional.sh around lines 36 - 40, The conditional that checks UNAME_M and sets skip_args is redundant because skip_args is already initialized to "--skip sriov"; remove the entire if [[ "${UNAME_M}" =~ aarch64 ]]; then ... fi block so skip_args remains set once, or if aarch64 actually needs different behavior, change the assignment inside that block to the intended value instead of repeating "--skip sriov"; refer to the skip_args variable and the UNAME_M check in the diff to locate and update the code.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@test/scenarios-bootc/periodics/el102-src`@standard-suite1.sh:
- Around line 14-17: In scenario_run_tests() update the EXPECTED_OS_VERSION
variable value from "10.0" to "10.2" in the run_tests invocation (the --variable
"EXPECTED_OS_VERSION:10.0" argument) so the el102 scenario matches the RHEL 10.2
naming convention used elsewhere.
---
Nitpick comments:
In `@test/scenarios-bootc/releases/el102-lrel`@optional.sh:
- Around line 36-40: The conditional that checks UNAME_M and sets skip_args is
redundant because skip_args is already initialized to "--skip sriov"; remove the
entire if [[ "${UNAME_M}" =~ aarch64 ]]; then ... fi block so skip_args remains
set once, or if aarch64 actually needs different behavior, change the assignment
inside that block to the intended value instead of repeating "--skip sriov";
refer to the skip_args variable and the UNAME_M check in the diff to locate and
update the code.
|
@vanhalenar: This pull request references USHIFT-6498 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vanhalenar: This pull request references USHIFT-6498 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vanhalenar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary by CodeRabbit