CNV- 59580: Added note to Configuring PCI passthrough#106357
CNV- 59580: Added note to Configuring PCI passthrough#106357Vaishali-gif-rh wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
size/M
rbo
left a comment
rbo
left a comment
There was a problem hiding this comment.
LGTM
Just a tiny change request. Thank you.
| ==== | ||
| For `vfio-pci` to allocate a PCI device, no other kernel driver can manage that device. If a driver is already managing the device, you must blacklist the specific kernel module. | ||
|
|
||
| Blacklisting a module makes all devices handled by that module unavailable to the host. |
There was a problem hiding this comment.
Tiny change, let's write kernel module instead of just module
Blacklisting a kernel module ...
There was a problem hiding this comment.
@Vaishali-gif-rh I don't see this update in the PR
|
🤖 Wed Feb 11 10:57:08 - Prow CI generated the docs preview: |
virt/managing_vms/advanced_vm_management/virt-configuring-pci-passthrough.adoc
Outdated
Show resolved
Hide resolved
Vaishali-gif-rh
force-pushed
the
CNV-59580
branch
2 times, most recently
from
f070174 to
b473b32
Compare
| Cluster administrators can expose and manage host devices that are permitted to be used in the cluster by using the `oc` command-line interface (CLI). | ||
|
|
||
| [IMPORTANT] | ||
| ==== |
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.ExampleBlock: Examples can not be inside of other blocks in DITA.
There was a problem hiding this comment.
Can you please address this?
Vaishali-gif-rh
force-pushed
the
CNV-59580
branch
from
b473b32 to
ac9ef12
Compare
|
@Vaishali-gif-rh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| ==== | ||
| For `vfio-pci` to allocate a PCI device, no other kernel driver can manage that device. If a driver is already managing the device, you must blacklist the specific kernel module. | ||
|
|
||
| Blacklisting a module makes all devices handled by that module unavailable to the host. |
There was a problem hiding this comment.
@Vaishali-gif-rh I don't see this update in the PR
| Cluster administrators can expose and manage host devices that are permitted to be used in the cluster by using the `oc` command-line interface (CLI). | ||
|
|
||
| [IMPORTANT] | ||
| ==== |
There was a problem hiding this comment.
Can you please address this?
|
|
||
| [IMPORTANT] | ||
| ==== | ||
| For `vfio-pci` to allocate a PCI device, no other kernel driver can manage that device. If a driver is already managing the device, you must blacklist the specific kernel module. |
There was a problem hiding this comment.
Per inclusive language guidelines, do not use "blacklist". Use "blocklist" instead.
| For `vfio-pci` to allocate a PCI device, no other kernel driver can manage that device. If a driver is already managing the device, you must blacklist the specific kernel module. | |
| For `vfio-pci` to allocate a PCI device, no other kernel driver can manage that device. If a driver already manages the device, you must add the specific kernel module to a blocklist. |
| ==== | ||
| For `vfio-pci` to allocate a PCI device, no other kernel driver can manage that device. If a driver is already managing the device, you must blacklist the specific kernel module. | ||
|
|
||
| Blacklisting a module makes all devices handled by that module unavailable to the host. |
There was a problem hiding this comment.
| Blacklisting a module makes all devices handled by that module unavailable to the host. | |
| Adding a kernel module to a blocklist makes all devices handled by that module unavailable to the host. |
| Blacklisting a module makes all devices handled by that module unavailable to the host. | ||
| ==== | ||
|
|
||
| * Example MachineConfig to blacklist the enic kernel module |
There was a problem hiding this comment.
I don't think you need this line because line 29 already explains what the example shows
| * Example MachineConfig to blacklist the enic kernel module |
| ==== | ||
|
|
||
| * Example MachineConfig to blacklist the enic kernel module | ||
| ==== |
| - enic.blacklist=1 | ||
| - rd.driver.blacklist=enic | ||
| ---- | ||
| ==== |
|
|
||
| * Example MachineConfig to blacklist the enic kernel module | ||
| ==== | ||
| The following example demonstrates a `MachineConfig` CR that blacklists the `enic` network driver by creating a configuration file in `/etc/modprobe.d/` and adding kernel arguments: |
There was a problem hiding this comment.
| The following example demonstrates a `MachineConfig` CR that blacklists the `enic` network driver by creating a configuration file in `/etc/modprobe.d/` and adding kernel arguments: | |
| The following example shows a `MachineConfig` CR that adds the `enic` network driver to a blocklist by creating a configuration file in `/etc/modprobe.d/` and adding kernel arguments: |
5 participants
Version(s):
4.17+
Issue:
https://issues.redhat.com/browse/CNV-59580
Link to docs preview:
https://106357--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-configuring-pci-passthrough.html
QE review: