CNTRLPLANE-2737: Add pre-commit quality review to jira-agent pipeline

[bryan-cox]

Summary

• Adds /code-review:pre-commit-quality-review from ai-helpers as a second Claude session in the jira-agent prow job
• Restructures the pipeline into three phases: solve, review, then PR creation
• PR creation is now handled by the shell script via gh pr create instead of by Claude during jira-solve

Changes

The jira-agent process step now runs a three-phase pipeline per issue:

Phase 1 - Solve: Runs /jira-solve to implement, commit, and push changes to the fork branch. The FORK_CONTEXT instructions now tell Claude to skip PR creation so the review can run first.

Phase 2 - Review: Runs /code-review:pre-commit-quality-review from ai-helpers in a clean Claude session. The review examines the diff against main using Go language and HyperShift profile skills, fixes any quality issues found, and pushes corrections to the same branch. If the skill is unavailable or the review fails, the pipeline continues gracefully.

Phase 3 - PR Creation: Creates a draft PR via gh pr create with a structured body referencing the Jira issue and listing all commits (including any review fixes).

Additional improvements:

• Resets the repo to main between issues to ensure clean state when processing multiple issues per run
• Skill loading is done once at startup, not per-issue

Jira

https://issues.redhat.com/browse/CNTRLPLANE-2737

Test plan

• Verify the pre-commit-quality-review skill is loaded from ai-helpers at startup
• Verify jira-solve runs without creating a PR (Phase 1)
• Verify the review runs in a clean Claude session against the committed diff (Phase 2)
• Verify the PR is created via gh CLI after review completes (Phase 3)
• Verify graceful skip when pre-commit-quality-review skill is not found in ai-helpers
• Verify graceful continuation when the review step fails
• Verify no code changes case skips both review and PR creation

Always review AI generated responses prior to use.

🤖 Generated with Claude Code via /jira:solve [CNTRLPLANE-2737](https://issues.redhat.com//browse/CNTRLPLANE-2737)

[openshift-ci-robot]

@bryan-cox: This pull request references CNTRLPLANE-2737 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

• Adds /code-review:pre-commit-quality-review from ai-helpers as a second Claude session in the jira-agent prow job
• Restructures the pipeline into three phases: solve, review, then PR creation
• PR creation is now handled by the shell script via gh pr create instead of by Claude during jira-solve

Changes

The jira-agent process step now runs a three-phase pipeline per issue:

Phase 1 - Solve: Runs /jira-solve to implement, commit, and push changes to the fork branch. The FORK_CONTEXT instructions now tell Claude to skip PR creation so the review can run first.

Phase 2 - Review: Runs /code-review:pre-commit-quality-review from ai-helpers in a clean Claude session. The review examines the diff against main using Go language and HyperShift profile skills, fixes any quality issues found, and pushes corrections to the same branch. If the skill is unavailable or the review fails, the pipeline continues gracefully.

Phase 3 - PR Creation: Creates a draft PR via gh pr create with a structured body referencing the Jira issue and listing all commits (including any review fixes).

Additional improvements:

• Resets the repo to main between issues to ensure clean state when processing multiple issues per run
• Skill loading is done once at startup, not per-issue

Jira

https://issues.redhat.com/browse/CNTRLPLANE-2737

Test plan

• Verify the pre-commit-quality-review skill is loaded from ai-helpers at startup
• Verify jira-solve runs without creating a PR (Phase 1)
• Verify the review runs in a clean Claude session against the committed diff (Phase 2)
• Verify the PR is created via gh CLI after review completes (Phase 3)
• Verify graceful skip when pre-commit-quality-review skill is not found in ai-helpers
• Verify graceful continuation when the review step fails
• Verify no code changes case skips both review and PR creation

Always review AI generated responses prior to use.

🤖 Generated with Claude Code via /jira:solve [CNTRLPLANE-2737](https://issues.redhat.com//browse/CNTRLPLANE-2737)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/hypershift/jira-agent/OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bryan-cox]

/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-jira-agent

[openshift-ci-robot]

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[bryan-cox]

/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-jira-agent

[openshift-ci-robot]

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@bryan-cox: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-hypershift-release-4.22-periodic-jira-agent	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-main-periodic-jira-agent	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-5.0-periodic-jira-agent	N/A	periodic	Registry content changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.