Skip to content

Conversation

@esyr
Copy link
Member

@esyr esyr commented Nov 11, 2025

The changes address the following compiler warnings (reported by GCC 14):

ssl_poll_perf.c: In function ‘srvapp_setup_response’:
ssl_poll_perf.c:1553:33: warning: variable ‘pesb’ set but not used [-Wunused-but-set-variable]
 1553 |     struct poll_event_sbstream *pesb;
      |                                 ^~~~
ssl_poll_perf.c: In function ‘clntapp_write_custreamcb’:
ssl_poll_perf.c:2389:28: warning: unused variable ‘rb’ [-Wunused-variable]
 2389 |     struct request_buffer *rb;
      |                            ^~
ssl_poll_perf.c: In function ‘clntapp_update_pec’:
ssl_poll_perf.c:2469:9: warning: variable ‘e’ set but not used [-Wunused-but-set-variable]
 2469 |     int e;
      |         ^
ssl_poll_perf.c: In function ‘main’:
ssl_poll_perf.c:3138:9: warning: unused variable ‘ccount’ [-Wunused-variable]
 3138 |     int ccount = 0;
      |         ^~~~~~
ssl_poll_perf.c: At top level:
ssl_poll_perf.c:1007:1: warning: ‘stream_state_str’ defined but not used [-Wunused-function]
 1007 | stream_state_str(int stream_state)
      | ^~~~~~~~~~~~~~~~
ssl_poll_perf.c:954:1: warning: ‘err_str_n’ defined but not used [-Wunused-function]
  954 | err_str_n(unsigned long e, char *buf, size_t buf_sz)
      | ^~~~~~~~~

@esyr esyr requested review from Sashan and quarckster November 11, 2025 12:47
@esyr esyr force-pushed the esyr/ssl_poll_perf-warnings branch 5 times, most recently from 023cd96 to 868d95c Compare November 11, 2025 13:28
@esyr esyr force-pushed the esyr/ssl_poll_perf-warnings branch from 868d95c to 432cdf0 Compare November 11, 2025 14:52
@esyr esyr requested a review from mattcaswell November 11, 2025 14:52
esyr added 2 commits November 11, 2025 15:59
The changes address the following compiler warnings (reported by GCC 14):

    ssl_poll_perf.c: In function ‘srvapp_setup_response’:
    ssl_poll_perf.c:1553:33: warning: variable ‘pesb’ set but not used [-Wunused-but-set-variable]
     1553 |     struct poll_event_sbstream *pesb;
          |                                 ^~~~
    ssl_poll_perf.c: In function ‘clntapp_write_custreamcb’:
    ssl_poll_perf.c:2389:28: warning: unused variable ‘rb’ [-Wunused-variable]
     2389 |     struct request_buffer *rb;
          |                            ^~
    ssl_poll_perf.c: In function ‘clntapp_update_pec’:
    ssl_poll_perf.c:2469:9: warning: variable ‘e’ set but not used [-Wunused-but-set-variable]
     2469 |     int e;
          |         ^
    ssl_poll_perf.c: In function ‘main’:
    ssl_poll_perf.c:3138:9: warning: unused variable ‘ccount’ [-Wunused-variable]
     3138 |     int ccount = 0;
          |         ^~~~~~
    ssl_poll_perf.c: At top level:
    ssl_poll_perf.c:1007:1: warning: ‘stream_state_str’ defined but not used [-Wunused-function]
     1007 | stream_state_str(int stream_state)
          | ^~~~~~~~~~~~~~~~
    ssl_poll_perf.c:954:1: warning: ‘err_str_n’ defined but not used [-Wunused-function]
      954 | err_str_n(unsigned long e, char *buf, size_t buf_sz)
          | ^~~~~~~~~

Complements: openssl#64
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
…h -DDEBUG

As the built with this macro set is not checked otherwise.

Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
@esyr esyr force-pushed the esyr/ssl_poll_perf-warnings branch from 432cdf0 to c859c86 Compare November 11, 2025 14:59
@Sashan Sashan merged commit 2074172 into openssl:main Nov 12, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants