Skip to content

Conversation

@kstrenkova
Copy link
Contributor

This change is needed for the introduction of new parameter expectedFailuresList to the test operator. The parameter will be used for ignoring results of specified tests that are expected to fail.

This change is needed for the introduction of new parameter
expectedFailuresList to the test operator. The parameter will be
used for ignoring results of specified tests that are expected to
fail.
@github-actions github-actions bot marked this pull request as draft November 21, 2024 14:43
@github-actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@pablintino
Copy link
Contributor

I guess this PR should be on hold till the operator CRD exposes the parameter isn't it?

Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kstrenkova! Looks good to me 👍

@lpiwowar
Copy link
Contributor

@pablintino The parameter is already exposed -> openstack-k8s-operators/test-operator#233

@lpiwowar lpiwowar requested a review from a team November 22, 2024 08:21
@pablintino
Copy link
Contributor

/approve
/lgtm (from @lpiwowar)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino
Copy link
Contributor

/lgtm
(from @lpiwowar)

@openshift-ci openshift-ci bot added the lgtm label Nov 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 924f1e8 into openstack-k8s-operators:main Nov 22, 2024
7 checks passed
@kstrenkova
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@kstrenkova: new pull request created: #2728

Details

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants