Skip to content

Conversation

@frenzyfriday
Copy link
Contributor

@frenzyfriday frenzyfriday commented Jan 25, 2025

This patch should go together with openshift/release#60916 (doesnt matter after or before)

This action checks if the PR has do-not-merge/hold or do-not-merge/work-in-progress. If yes it fails.
When this action is set as "required" in the repo settings this prevents accidental merge if these labels are set.

The contains() function does not support regexes or arrays - hence the use of "or"

@pablintino
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino
Copy link
Contributor

/lgtm

Copy link

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@frenzyfriday frenzyfriday merged commit 475d689 into openstack-k8s-operators:main Jan 28, 2025
6 of 7 checks passed
@openshift-ci openshift-ci bot added the lgtm label Jan 28, 2025
@pablintino
Copy link
Contributor

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@pablintino: new pull request created: #2704

Details

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants