-
Notifications
You must be signed in to change notification settings - Fork 141
Remove DS tigger PoC content #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
frenzyfriday
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These as well:
- https://github.com/openstack-k8s-operators/ci-framework/blob/main/.github/workflows/trigger-downstream-job.yaml
- https://github.com/openstack-k8s-operators/ci-framework/blob/main/.github/workflows/github-action-trigger-downstream-job-reusable-workflow.yaml
I can remove these two later on
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshewale The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
evallesp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
recheck |
b95debc
f1995e8 to
b95debc
Compare
Fixed in the latest patch version. |
lewisdenny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pablintino
|
/cherry-pick 18.0-fr1 |
|
@pablintino: new pull request created: #2713 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Remove reference to deleted downstream workflow The workflow referenced no longer exists in CIFMW [1] and throws an error whenever someone comments on a PR. [1] openstack-k8s-operators/ci-framework#2703 Reviewed-by: John Fulton <johfulto@redhat.com>
The two downstream-* jobs had been removed here: openstack-k8s-operators/ci-framework#2703 A few references were later removed here: openstack-k8s-operators#495 But it seems zuul started to complain very recently (today?) about the missing definitions.
Remove references to downstream-* trigger jobs The two downstream-* jobs had been removed here: openstack-k8s-operators/ci-framework#2703 A few references were later removed here: #495 But it seems zuul started to complain very recently (today?) about the missing definitions. Reviewed-by: Andrew Bays <andrew.bays@gmail.com> Reviewed-by: John Fulton <johfulto@redhat.com>
The two downstream-* jobs had been removed here: openstack-k8s-operators/ci-framework#2703 A few references were later removed here: openstack-k8s-operators#495 But it seems zuul started to complain very recently (today?) about the missing definitions.
No description provided.