Skip to content

Add missing kubeconfig file name to shiftstack test #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rlobillo merged 1 commit into from
Feb 20, 2025
Merged

Add missing kubeconfig file name to shiftstack test #2743

rlobillo merged 1 commit into from
Feb 20, 2025

Conversation

@eurijon
Copy link
Contributor

@eurijon eurijon commented Feb 20, 2025

The kubeconfig file name was missing in the extra var rhoso_kubeconfig when running the shiftstack playbook inside the shiftstackclient pod.

@eurijon
Add missing kubeconfig file name to shiftstack test
66599de 
The kubeconfig file name was missing in the extra var rhoso_kubeconfig
when running the shiftstack playbook inside the shiftstackclient pod.
@eurijon eurijon requested a review from rlobillo as a code owner February 20, 2025 12:13
@rlobillo
Copy link
Contributor

rlobillo commented Feb 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 20, 2025
@rlobillo
Copy link
Contributor

rlobillo commented Feb 20, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rlobillo
Once this PR has been reviewed and has the lgtm label, please assign evallesp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rlobillo rlobillo enabled auto-merge (rebase) February 20, 2025 15:50
@rlobillo rlobillo merged commit 6c21b81 into openstack-k8s-operators:main Feb 20, 2025
5 checks passed
@eurijon
Copy link
Contributor Author

eurijon commented Feb 24, 2025

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 24, 2025

@eurijon: new pull request created: #2748

Details

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 24, 2025
Merged
@eurijon eurijon deleted the rhoso_kubeconfig_param branch February 25, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rlobillo rlobillo rlobillo approved these changes

+1 more reviewer

@pablintino pablintino pablintino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rlobillo rlobillo

Labels

lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eurijon @rlobillo @openshift-cherrypick-robot @pablintino