[18.0-fr1] Fix wait condition for OpenStack initialization resource #2777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Api version was not set and kind was wrong and due to this it do not wait for the ready state as there is no such resouce in the default api_version v1. This leads to failure of later tasks as operators are not ready.
openshift-cherrypick-robot
requested review from
bshewale,
evallesp,
frenzyfriday and
lewisdenny
as code owners
|
Thanks for the PR! ❤️ |
arxcruz
added
approved
ok-to-test
Ready For Review
and removed
do-not-merge/work-in-progress
labels
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
Contributor
|
/lgtm |
bshewale
approved these changes
Mar 5, 2025
evallesp
approved these changes
Mar 5, 2025
karelyatin
merged commit 1f7f72f
into
openstack-k8s-operators:18.0-fr1
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2718
/assign abays