Skip to content

Guarantee resources on shiftstackclient pod #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frenzyfriday merged 1 commit into from
Mar 13, 2025
Merged

Guarantee resources on shiftstackclient pod #2786

frenzyfriday merged 1 commit into from
Mar 13, 2025

Conversation

@rlobillo
Copy link
Contributor

@rlobillo rlobillo commented Mar 11, 2025 •
edited
Loading

It's observed that the rsh session is closed automatically reporting rc=0 which is provoking false success on the zuul job.

This patch guarantees that the pod has enough resources so the rsh session is never killed.

For adapting to the molecule test, the 'resource' section is set to empty if it runs on CRC.

@rlobillo rlobillo requested a review from eurijon as a code owner March 11, 2025 15:59
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign frenzyfriday for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rlobillo rlobillo force-pushed the shiftstack-resources branch 2 times, most recently from d60cad1 to cb6d9a6 Compare March 11, 2025 16:12
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Mar 11, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b1160c3734064a1faf0a5442daf62042

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 53s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 00s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 24m 59s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 22s
✔️ build-push-container-cifmw-client SUCCESS in 20m 55s
❌ cifmw-molecule-shiftstack FAILURE in 16m 38s

@rlobillo rlobillo force-pushed the shiftstack-resources branch from cb6d9a6 to 6aa490a Compare March 11, 2025 20:15
@frenzyfriday
Copy link
Contributor

frenzyfriday commented Mar 12, 2025

Do you have a testproject/job running with this?

@rlobillo rlobillo force-pushed the shiftstack-resources branch from 6aa490a to c7b0fa0 Compare March 12, 2025 07:58
@rlobillo
Copy link
Contributor Author

rlobillo commented Mar 12, 2025 •
edited
Loading

Do you have a testproject/job running with this?

Yes! Testing on https://gitlab.cee.redhat.com/ci-framework/ci-framework-testproject/-/merge_requests/1096. Still WIP

@rlobillo rlobillo marked this pull request as draft March 12, 2025 08:01
@eurijon
Copy link
Contributor

eurijon commented Mar 12, 2025

Hey @rlobillo the change lgtm, can you please add (in commit msg and PR description if possible) why the condition for crc is needed? :) thanks

@rlobillo
Copy link
Contributor Author

rlobillo commented Mar 12, 2025

recheck

@rlobillo rlobillo marked this pull request as ready for review March 12, 2025 15:47
@rlobillo rlobillo force-pushed the shiftstack-resources branch from f520473 to c7b0fa0 Compare March 12, 2025 16:22
@rlobillo
Guarantee resources on shiftstackclient pod
729584c 
It's observed that the rsh session is closed automatically reporting
rc=0 which is provoking false succeeds on the zuul job.

This patch guarantees that the pod has enough resources so the rsh
session is never killed.
@rlobillo rlobillo force-pushed the shiftstack-resources branch from c7b0fa0 to 729584c Compare March 12, 2025 16:23
@eurijon
Copy link
Contributor

eurijon commented Mar 12, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 12, 2025
@rlobillo
Copy link
Contributor Author

rlobillo commented Mar 12, 2025

Change successfully tested on https://sf.apps.int.gpc.ocp-hub.prod.psi.redhat.com/zuul/t/components-integration/build/9b0d5c495a1948728bf45989b4f66ad6.

@frenzyfriday would you mind to merge?

@frenzyfriday frenzyfriday enabled auto-merge (rebase) March 13, 2025 09:24
@frenzyfriday frenzyfriday merged commit 3dc53b6 into openstack-k8s-operators:main Mar 13, 2025
5 checks passed
@rlobillo
Copy link
Contributor Author

rlobillo commented Mar 13, 2025

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 13, 2025

@rlobillo: new pull request created: #2791

Details

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eurijon eurijon eurijon approved these changes

@bshewale bshewale bshewale approved these changes

@frenzyfriday frenzyfriday frenzyfriday approved these changes

Assignees

@eurijon eurijon

Labels

lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rlobillo @frenzyfriday @eurijon @openshift-cherrypick-robot @bshewale