Skip to content

Conversation

@maximsava12
Copy link
Contributor

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

Hi @maximsava12. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tosky
Copy link
Contributor

tosky commented Jul 31, 2025

If you are testing #3169, you don't need this.
You can just either:

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ca7228c9693840ad8c09f6b3a461fb67

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 24s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 48s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 49s
podified-multinode-hci-deployment-crc FAILURE in 50m 57s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 14s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 37s
✔️ build-push-container-cifmw-client SUCCESS in 17m 01s
cifmw-molecule-cifmw_ceph_client FAILURE in 4m 20s

@maximsava12 maximsava12 force-pushed the fix-cinder-multiattach-volume-hook branch from daf7912 to 68d8a12 Compare July 31, 2025 11:23
@maximsava12 maximsava12 force-pushed the fix-cinder-multiattach-volume-hook branch from 68d8a12 to 870dd2a Compare July 31, 2025 11:37
Missing namespace var in shell script
@maximsava12 maximsava12 force-pushed the fix-cinder-multiattach-volume-hook branch from 870dd2a to 7d5567b Compare July 31, 2025 12:11
@tosky tosky marked this pull request as ready for review July 31, 2025 14:12
@tosky
Copy link
Contributor

tosky commented Jul 31, 2025

I would say we need this

@tosky
Copy link
Contributor

tosky commented Jul 31, 2025

/lgtm

Copy link
Contributor

@sdatko sdatko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed it... Thanks!

@sdatko sdatko merged commit 188baa6 into openstack-k8s-operators:main Jul 31, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants