-
Notifications
You must be signed in to change notification settings - Fork 141
Drop unused playbooks except 08-run-tests.yml #3193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
It was just a PoC. It requires to change/update docs. |
and to the existing consumers of these playbooks, which are not unused. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/56e1469b1ee443d5b7e93fea155f4253 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 23s |
f237f02 to
bded5aa
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4730909439354ebab4465d6d3049408d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 06s |
bded5aa to
bcf3bee
Compare
|
This change depends on a change that failed to merge. Change https://review.rdoproject.org/r/c/rdo-jobs/+/58122 is needed. |
|
recheck |
|
This change depends on a change that failed to merge. Change https://review.rdoproject.org/r/c/rdo-jobs/+/58122 is needed. |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/182f45367be24d6caad59c86125184e1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 20s |
| # DO NOT EDIT THAT PLAYBOOK. IT WOULD BE REMOVED IN NEAR FUTURE. | ||
| # | ||
|
|
||
| - name: Logging playbook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(blocking) AFAIK we cannot remove this right? Still used in e2e collect logs: #3206 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also we have occurrence in downstream as well I don't know i can put the link here or not but you can check in the ci-framework-jobs repo of playbooks/baremetal/collect-controller-logs.yaml#L12
And Also not sure other playbooks are getting used in the downstream.
bcf3bee to
dffb14f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/eddc6fe1c6d64cec84302a5dfad881eb ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 08s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/37e207d453ee417984249cccac3d22e2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 33m 55s |
dffb14f to
bd220e0
Compare
|
This change depends on a change that failed to merge. Change https://review.rdoproject.org/r/c/rdo-jobs/+/58122 is needed. |
|
recheck |
bd220e0 to
e6f0382
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7dc676e181454741905ecfd218bca15a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 39s |
937dd34 to
0075618
Compare
|
Excluded 08-run-tests.yml playbook due @openstack-k8s-operators/nfv is verifying changes. |
0075618 to
4d155c7
Compare
3658556 to
5605adf
Compare
5605adf to
043ae5d
Compare
|
This PR is stale because it has been for over 15 days with no activity. |
The playbooks were migrated into role cifmw_setup. As it was mentioned in commit message [1], such approach should be better for developers to maintain the code. Also skip removing 08-run-tests.yml because the NFV team is using it and it takes a time to verify that. The playbook would be removed in next pull request. [1] openstack-k8s-operators#2930 Depends-On: https://review.rdoproject.org/r/c/rdo-jobs/+/58147 Depends-On: openstack-k8s-operators#3208 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
043ae5d to
3780120
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/52f52bfbd922461bbb2b9fc23556b918 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 21m 23s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/909e4b0b86db4a1492e2327187730edb ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 05m 45s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/662bc54667dd471e8d276ce6cafbf7fd ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 18m 33s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ce137b7390764976863051ca4f6bb3f4 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 47s |
|
recheck |
The playbooks were migrated into role cifmw_setup.
As it was mentioned in commit message [1], such approach
should be better for developers to maintain the code.
Also skip removing 08-run-tests.yml because the NFV team is using it
and it takes a time to verify that. The playbook would be removed in
next pull request.
[1] #2930
Depends-On: https://review.rdoproject.org/r/c/rdo-jobs/+/58147
Depends-On: #3208