Fix check-role-prefix pattern regexp #3474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
It seems backlash was creating ambiguity, as different regex engines handle this different. Now is using special positioning rule technique. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
fix-check-role-prefix-regexp
branch
from
047bc2a to
64e6813
Compare
amartyasinha
previously approved these changes
Nov 12, 2025
rebtoor
requested changes
Nov 12, 2025
Contributor
rebtoor
left a comment
rebtoor
left a comment
There was a problem hiding this comment.
try this. I'm escaping every special char in the name. It should address every "corner case" we have :)
rebtoor
previously approved these changes
Nov 12, 2025
Apply rebtoor suggestion about adding scaping special characters in role names. So now roles can have special characters "*" and "." as they're escaped. Co-authored-by: Roberto Alfieri <538845+rebtoor@users.noreply.github.com> Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
fix-check-role-prefix-regexp
branch
from
8964d68 to
5bf2fce
Compare
amartyasinha
previously approved these changes
Nov 12, 2025
Valkyrie00
previously approved these changes
Nov 12, 2025
evallesp
dismissed stale reviews from Valkyrie00, amartyasinha, and rebtoor
via
3604cbf
evallesp
force-pushed
the
fix-check-role-prefix-regexp
branch
from
3604cbf to
8721a89
Compare
rebtoor
previously approved these changes
Nov 12, 2025
We're skipping Single quotes in sed as we want literal $ in the sed pattern, not shell expansion. Added this file to irrelevant-files. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
fix-check-role-prefix-regexp
branch
from
8721a89 to
a85d191
Compare
rebtoor
approved these changes
Nov 12, 2025
brjackma
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems backlash was creating ambiguity, as different regex engines handle this different.
Now is using special positioning rule technique.