Skip to content

[hooks] Add install-openstack-lightspeed hook #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
evallesp merged 1 commit into from
Dec 9, 2025
Merged

[hooks] Add install-openstack-lightspeed hook #3500

evallesp merged 1 commit into from
Dec 9, 2025

Conversation

@malingatembo
Copy link

@malingatembo malingatembo commented Nov 19, 2025

Summary

This PR adds a hook to install OpenStack Lightspeed operators on CRC-based CI Framework deployments.

Background

OpenStack Lightspeed operators are not deployed by default in CRC-based deployments. This hook enables teams to add OpenStack Lightspeed capabilities to their CI Framework deployments.

The hook deploys two operators sequentially:

  1. OpenShift Lightspeed (foundation operator from Red Hat catalog)
  2. OpenStack Lightspeed (custom catalog source)

For each operator, the hook:

  • Creates the required namespace
  • Configures OperatorGroup with target namespace
  • Creates Subscription resource
  • Waits for operator deployment to be ready (30 retries x 10s)

Additionally, for OpenShift Lightspeed, it configures the service-ca bundle required for metrics collection.

The hook is configurable via cifmw_* variables for namespace names, catalog images, and kubeconfig path, defaulting to standard CRC paths.

Tested with successful deployments on CRC clusters.

Intent

This is primarily for our internal team use. We're submitting to:

  • Confirm we're following CI Framework hook standards
  • Share with the community in case others find it useful
  • Get feedback on our approach

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

umago
umago reviewed Nov 19, 2025
View reviewed changes
lpiwowar
lpiwowar reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments but overall it looks good! I'm looking forward when we use it in our CI:) 👍 Thank you!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dasm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@malingatembo malingatembo force-pushed the add-OStack-lightspeed-hook branch from 8df440f to c507c5c Compare November 25, 2025 10:26
@umago
Copy link

umago commented Nov 26, 2025

The new version does looks good to me. I would just squash both commits into one to make the PR more coherent

@malingatembo malingatembo force-pushed the add-OStack-lightspeed-hook branch 2 times, most recently from 7d202c0 to cb67165 Compare November 26, 2025 14:50
@malingatembo
Copy link
Author

malingatembo commented Nov 26, 2025

@umago @lpiwowar Thank you both for the thorough review! I've addressed all feedback:

Lucas's feedback:

  • Removed manual OpenShift Lightspeed installation
  • Squashed into single commit (after implementing all the reviewer suggestions)

Lukasz's feedback:

  • Changed namespace to openshift-lightspeed
  • Added configurable host via cifmw_target_hook_host
  • Changed to CSV status check instead of Deployment check
  • Removed metrics-client-ca (not longer needed with auto-installation)

lpiwowar
lpiwowar reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me! 👍 Just a couple of small comments and one important question. Thank you!:) 🙏

@umago
Copy link

umago commented Dec 2, 2025

Should we mark this PR as ready for review (outside draft) ?

@malingatembo malingatembo force-pushed the add-OStack-lightspeed-hook branch 2 times, most recently from 121c3f1 to 53092c6 Compare December 2, 2025 11:13
@malingatembo malingatembo marked this pull request as ready for review December 2, 2025 11:15
@malingatembo malingatembo force-pushed the add-OStack-lightspeed-hook branch from 53092c6 to d97fb73 Compare December 2, 2025 12:46
@malingatembo malingatembo force-pushed the add-OStack-lightspeed-hook branch from d97fb73 to 5eecc23 Compare December 3, 2025 10:46
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 3, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7ecd7fd4b74d4471aec2bbf1a3b7c6ee

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 46m 18s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 26m 54s
❌ cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 29m 28s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 40s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 32s
✔️ build-push-container-cifmw-client SUCCESS in 22m 18s

@malingatembo
Copy link
Author

malingatembo commented Dec 3, 2025

recheck

@malingatembo
Copy link
Author

malingatembo commented Dec 3, 2025

rechech

@malingatembo
Copy link
Author

malingatembo commented Dec 3, 2025

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 3, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a75f36e8e6494432a3c6c6c821583a82

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 24m 29s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 43s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 46m 48s
❌ cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 2h 09m 55s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 30s
✔️ build-push-container-cifmw-client SUCCESS in 21m 28s

@malingatembo
Copy link
Author

malingatembo commented Dec 3, 2025

recheck

@malingatembo malingatembo requested review from danpawlik and raukadah and removed request for danpawlik December 4, 2025 14:09
@malingatembo malingatembo requested a review from cjeanner December 4, 2025 14:12
evallesp
evallesp reviewed Dec 5, 2025
View reviewed changes
Copy link
Contributor

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@malingatembo malingatembo force-pushed the add-OStack-lightspeed-hook branch from 4067017 to 2edf1ac Compare December 5, 2025 13:27
@malingatembo
[hooks] Add install-openstack-lightspeed hook
37db4a4 
This hook deploys the openstack lightspeed operator for OpenShift clusters.
The openstack lightspeed operator automatically manages the OpenShift
lightspeed operator as a dependency.

Signed-off-by: Malinga Tembo <mtembo@redhat.com>
@malingatembo malingatembo force-pushed the add-OStack-lightspeed-hook branch from 2edf1ac to 37db4a4 Compare December 5, 2025 13:59
lpiwowar
lpiwowar approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lpiwowar lpiwowar requested a review from umago December 8, 2025 08:37
umago
umago approved these changes Dec 8, 2025
View reviewed changes
Copy link

@umago umago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evallesp evallesp merged commit 5f5393f into openstack-k8s-operators:main Dec 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umago umago umago approved these changes

@lpiwowar lpiwowar lpiwowar approved these changes

@evallesp evallesp evallesp approved these changes

@raukadah raukadah Awaiting requested review from raukadah

@cjeanner cjeanner Awaiting requested review from cjeanner

Assignees

No one assigned

Labels

Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malingatembo @umago @lpiwowar @evallesp