Skip to content

[nat64_appliance] Download nat64 image #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hjensas merged 1 commit into from
Dec 12, 2025
Merged

[nat64_appliance] Download nat64 image #3545

hjensas merged 1 commit into from
Dec 12, 2025

Conversation

@mnietoji
Copy link
Contributor

@mnietoji mnietoji commented Dec 10, 2025 •
edited
Loading 

[nat64_appliance] Add support for downloading pre-built images

Introduce cifmw_nat64_appliance_image_url parameter to download
pre-built NAT64 images, with optional checksum verification support.

Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>

@mnietoji mnietoji force-pushed the nat64_download branch 2 times, most recently from 59a9790 to 18458d8 Compare December 10, 2025 09:02
@hjensas hjensas enabled auto-merge (rebase) December 10, 2025 09:35
hjensas
hjensas previously approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The molecule job passed, https://softwarefactory-project.io/zuul/t/rdoproject.org/build/637398ca48fc43fdbf147dd8ee4d19f9

LGTM. Thanks!

evallesp
evallesp previously approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@evallesp evallesp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Edit: This has a blocker, so not approving.

evallesp
evallesp reviewed Dec 10, 2025
View reviewed changes
@evallesp evallesp self-requested a review December 10, 2025 10:29
@evallesp evallesp dismissed their stale review December 10, 2025 10:29

no valid

@mnietoji mnietoji force-pushed the nat64_download branch 3 times, most recently from c6c3979 to 11ceb03 Compare December 10, 2025 11:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign amartyasinha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 10, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c5cc6858dbe04c2e89d7c1764cee8166

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 28s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 28m 29s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 30s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 24s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 11s
❌ cifmw-pod-pre-commit FAILURE in 8m 25s
✔️ build-push-container-cifmw-client SUCCESS in 17m 10s
❌ cifmw-molecule-nat64_appliance FAILURE in 17m 19s

@mnietoji mnietoji force-pushed the nat64_download branch 2 times, most recently from c344837 to 95f3db8 Compare December 10, 2025 13:43
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 10, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/63e9f9813a844401bad32864652163e5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 10s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 35s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 40m 15s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 36s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 09s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 44s
✔️ build-push-container-cifmw-client SUCCESS in 20m 07s
❌ cifmw-molecule-nat64_appliance FAILURE in 19m 54s

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 11, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3b47de65a3934955b9ae76706f682538

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 06m 37s
❌ podified-multinode-edpm-deployment-crc FAILURE in 38m 32s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 46m 07s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 32s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 31s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 53s
✔️ build-push-container-cifmw-client SUCCESS in 16m 28s
❌ cifmw-molecule-nat64_appliance POST_FAILURE in 9m 43s

@mnietoji
Copy link
Contributor Author

mnietoji commented Dec 11, 2025

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 11, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1f7a606a0bee47819e6fcd965248d094

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 37s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 27m 55s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 35m 49s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 27s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 27s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 05s
✔️ build-push-container-cifmw-client SUCCESS in 22m 06s
❌ cifmw-molecule-nat64_appliance FAILURE in 16m 14s

@mnietoji mnietoji force-pushed the nat64_download branch 2 times, most recently from 362705f to d27cfed Compare December 11, 2025 15:29
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 11, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9ba431bd86ed49f785b59a5f2ea54eef

❌ openstack-k8s-operators-content-provider FAILURE in 5m 54s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 4m 30s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 57s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 00s
✔️ build-push-container-cifmw-client SUCCESS in 17m 40s
❌ cifmw-molecule-nat64_appliance FAILURE in 14m 58s

@mnietoji mnietoji force-pushed the nat64_download branch 4 times, most recently from a2ec62c to 3f1a988 Compare December 12, 2025 08:57
@mnietoji
[nat64_appliance] Add support for downloading pre-built images
4f7154b 
Introduce cifmw_nat64_appliance_image_url parameter to download
pre-built NAT64 images, with optional checksum verification support.

Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 12, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dd53e8918946434b961695d80bb82c11

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 06m 24s
❌ podified-multinode-edpm-deployment-crc FAILURE in 35m 13s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 47m 23s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 30s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 36s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 47s
✔️ build-push-container-cifmw-client SUCCESS in 21m 02s
✔️ cifmw-molecule-nat64_appliance SUCCESS in 15m 41s

@mnietoji
Copy link
Contributor Author

mnietoji commented Dec 12, 2025

recheck

hjensas
hjensas reviewed Dec 12, 2025
View reviewed changes
Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I have a nit comment, but I don't think it should block merging this PR.

@openshift-ci openshift-ci bot added the lgtm label Dec 12, 2025
@hjensas hjensas merged commit e478c44 into openstack-k8s-operators:main Dec 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjensas hjensas hjensas approved these changes

@evallesp evallesp evallesp approved these changes

Assignees

@hjensas hjensas

Labels

lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnietoji @hjensas @evallesp