Skip to content

Conversation

@danpawlik
Copy link
Contributor

Reverts #3514

Currently, many of the CI jobs "catch" the new assertion:

TASK [config_drive : Assert we don't try to change an existing ISO that=['_meta_data_change is not changed', '_user_data_change is skipped or _user_data_change is not changed', '_net_data_change is not changed'], msg=You're trying to edit an existing ISO. This isn't possible, since the ISO is usually attached to a virtual machine, and you cannot dynamically edit it.] ***
Wednesday 17 December 2025  08:16:54 +0000 (0:00:01.031)       0:08:14.694 ****
Wednesday 17 December 2025  08:16:54 +0000 (0:00:01.031)       0:08:14.693 ****
task path: /home/zuul/src/github.com/openstack-k8s-operators/ci-framework/roles/config_drive/tasks/main.yml:81
fatal: [hypervisor]: FAILED! =>
    assertion: _user_data_change is skipped or _user_data_change is not changed
    changed: false
    evaluated_to: false
    msg: You're trying to edit an existing ISO. This isn't possible, since the ISO is
      usually attached to a virtual machine, and you cannot dynamically edit it.

@pinikomarov
Copy link
Contributor

LGTM

@pinikomarov pinikomarov enabled auto-merge (rebase) December 17, 2025 08:33
@danpawlik danpawlik requested review from a team and pinikomarov December 17, 2025 08:33
@rebtoor
Copy link
Contributor

rebtoor commented Dec 17, 2025

/approve

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danpawlik danpawlik disabled auto-merge December 17, 2025 08:34
@danpawlik danpawlik merged commit 052ccea into main Dec 17, 2025
4 of 8 checks passed
@danpawlik danpawlik deleted the revert-3514-fix_existing_ISO_check branch December 17, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants