Group-Vars: Create the cifmw_manifests_dir group var#3636
Group-Vars: Create the cifmw_manifests_dir group var#3636brjackma wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
brjackma
force-pushed
the
manifests_dir
branch
from
17612e3 to
c80baef
Compare
|
Link to testproject outputs can be found in Jira: https://issues.redhat.com/browse/OSPRH-22661 |
|
recheck |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d30d6c6f662c4103ba494490d7224c48 ❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0008160530 failed in 0s |
|
recheck |
|
recheck |
There was a problem hiding this comment.
I think this is missing:
playbooks/dcn.yml: dest: "{{ ansible_user_dir }}/ci-framework-data/artifacts/manifests/openstack/cr"
roles/kustomize_deploy/tasks/cleanup.yml: - "{{ ansible_user_dir }}/ci-framework-data/artifacts/manifests/cifmw_external_dns/ceph-local-dns.yml"
roles/kustomize_deploy/tasks/cleanup.yml: - "{{ ansible_user_dir }}/ci-framework-data/artifacts/manifests/cifmw_external_dns/ceph-local-cert.yml"
Also why you include (Jira: OSPRH-22661) instead add into the commit message information to Jira task? I think we agree with whole team that we put only role(s) name into the commit message title and if Jira task, it should be as commit message, here I see exception.
Also worth to mention that another Jira is related to it: OSPRH-26441
- Create the cifmw_manifests_dir to replace previous instances of "{{ cifmw_basedir }}/artifacts/manifests"
- This new var should be used throughout the entire framework
- Related Jira tasks: (OSPRH-22661) & (OSPRH-26441)
Signed-off-by: Brian Jackman <brjackma@redhat.com>
brjackma
force-pushed
the
manifests_dir
branch
from
c80baef to
a6220d0
Compare
brjackma
changed the title
|
recheck |
2 participants
Signed-off-by: Brian Jackman brjackma@redhat.com