Add edpm_ssh_info role for retrieving EDPM SSH connectivity information#3650
Add edpm_ssh_info role for retrieving EDPM SSH connectivity information#3650rdiazcam wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9b7d9eb816dd47a0ba9b6c2bc66af485 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 05s |
b950629 to
e316345
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f0648324700d48078817b57caaffd192 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 34s |
danpawlik
left a comment
There was a problem hiding this comment.
please run make role_molecule . Thanks
e316345 to
172626d
Compare
done, thanks |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ea9330c8d985419b9f0dfb1e29d8476c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 13s |
|
recheck |
danpawlik
left a comment
There was a problem hiding this comment.
please remove role os_flavor and execute again make role_molecule
172626d to
1ac8102
Compare
evallesp
left a comment
There was a problem hiding this comment.
I see there's no molecule tests but I also see that might be hard to set.
LGTM in general.
1ac8102 to
6139153
Compare
6139153 to
691543e
Compare
691543e to
ad9fb5e
Compare
ad9fb5e to
e6a99f0
Compare
michburk
left a comment
There was a problem hiding this comment.
One request otherwise lgtm.
Also just want to check, have you tested this, and is everything working as expected?
Thanks!
This role queries OpenShift for OpenStackDataPlaneNodeSet resources, retrieves SSH credentials, and returns node information for external data plane management (SSH connectivity). Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Ricardo Diaz <rdiazcam@redhat.com>
e6a99f0 to
e2fbd98
Compare
| ansible.builtin.set_fact: | ||
| cifmw_edpm_ssh_info: | ||
| ssh_key_path: "{{ cifmw_edpm_ssh_info_ssh_key_path }}" | ||
| nodes: >- |
There was a problem hiding this comment.
nit: consider to change variable name to something different, that would be helpful to recognize place, where it has been set.
In other words, other people might think that the nodes var comes from CI (Zuul), but we set the fact here. More, the var is common, so changing var to other name might be helpful in future when debug is needed.
danpawlik
left a comment
There was a problem hiding this comment.
One nit, that might be helpful to save some time on debug.
This role queries OpenShift for OpenStackDataPlaneNodeSet resources, retrieves SSH credentials, and returns node information for external data plane management.
Assisted-By: Claude Sonnet 4.5 noreply@anthropic.com