[set_openstack_containers] Fix default ironic python agent image name#3659
[set_openstack_containers] Fix default ironic python agent image name#3659sathlan wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
ValidationWhen using that patch with #3627 we create [zuul@controller-0 ~]$ grep RELATED_IMAGE_IRONIC_PYTHON_AGENT_IMAGE_URL_DEFAULT /home/zuul/ci-framework-data/artifacts/update_env_vars.sh
| jq '(.spec.install.spec.deployments[]?.spec.template.spec.containers[]?.env[]? | select(.name=="RELATED_IMAGE_IRONIC_PYTHON_AGENT_IMAGE_URL_DEFAULT"?)) |= (.value="images.paas.redhat.com/podified-rhos18-rhel9/ironic-python-agent:258bdd2f6d76a7a05936d0c4841120f9")' \The generated name look good: which is similar to what we have in a deployment only job: Then in the which eventually leads to a |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/13451333e49441fda73b5879ce2856a0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 13m 41s |
|
recheck |
|
/approve |
|
Do you want to also update roles/set_openstack_containers/README.md - it as the previous |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0eca788872f14e588d7274159fd90638 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 42s |
To get a match we need `RELATED_IMAGE_` prefix in the default for the ironic python agent. Signed-off-by: Sofer Athlan-Guyot <sathlang@redhat.com> Closes: [OSPCIX-1167](https://issues.redhat.com/browse/OSPCIX-1167)
sathlan
dismissed stale reviews from cjeanner, jistr, and ciecierski
via
e04d8ad
sathlan
force-pushed
the
OSPCIX-1167-update-env-vars-followup
branch
from
cb1f7f9 to
e04d8ad
Compare
|
in reply to @hjensas
Good catch, updated. |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0931e3bd44fe41b3affe2c2611366930 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 21s |
Job failing
recheck |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ded66b1cf99e430d80c9822ac5db50c3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 09s |
|
recheck |
danpawlik
left a comment
danpawlik
left a comment
There was a problem hiding this comment.
don't know who invented this prefix, but if it needs to be as it is - it is fine :)
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/917d14a6dc634b00b459a90549877ddb ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 17m 03s |
Unrelated current error in ci check ?Failing job: That seems totally unrelated to the change here, or am I missing something ? |
|
recheck |
|
@danpawlik or @kstrenkova can you add the lgtm label so that we can merge that one, it seems missing according to that check Thanks. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amartyasinha, rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/74a5e735ac534af184f14d27f34304d1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 13m 46s |
9 participants
To get a match we need
RELATED_IMAGE_prefix in the default for theironic python agent.
Signed-off-by: Sofer Athlan-Guyot sathlang@redhat.com
Closes: OSPCIX-1167