Skip to content

[config_drive] Fix conditional to handle NoneType properly #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holser wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[config_drive] Fix conditional to handle NoneType properly #3683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions roles/config_drive/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@

- name: Generate network-data
register: _net_data_change
when:
- cifmw_config_drive_networkconfig is not none
Copy link
Contributor

@hjensas hjensas Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.
The varialbe is defined in the role default, see: https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/config_drive/defaults/main.yml#L31-L32 - so it will be None or some value the user provided. The is not none test is safe here.

- cifmw_config_drive_networkconfig | length > 0
when: cifmw_config_drive_networkconfig | default({}) | length > 0
ansible.builtin.template:
backup: true
src: "network-config.j2"
Expand Down