-
Notifications
You must be signed in to change notification settings - Fork 47
Rabbitmq user/vhost/transporturl fixups #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lmiccini
wants to merge
1
commit into
openstack-k8s-operators:main
Choose a base branch
from
lmiccini:transport_user_permissions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rabbitmq user/vhost/transporturl fixups #516
lmiccini
wants to merge
1
commit into
openstack-k8s-operators:main
from
lmiccini:transport_user_permissions
+668
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2256f7f to
38c062c
Compare
192e84b to
8ba67af
Compare
Contributor
Author
|
/test infra-operator-build-deploy-kuttl |
stuggi
reviewed
Dec 19, 2025
8ba67af to
813aaa3
Compare
Contributor
Author
|
/test functional |
This commit fixes the followign issues: 1. lack of .* permissions when user is created via transporturl 2. missing reconciliation of the transporturl secret when vhost changes 3. missing permissions cleanup on old vhost 4. missing permissions setup on new vhost 5. missing removal of transporurl finalizer from vhost
813aaa3 to
7381f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the followign issues: