Fix AnsibleEE job name collisions for long names#1819
Fix AnsibleEE job name collisions for long names#1819holser wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
Previously, when the combined service + deployment + nodeset name exceeded 63 characters (DNS1123 max), simple truncation could cause different jobs to end up with identical names, leading to collisions. Replace the arbitrary -10 prefix truncation with a hash-based approach: - Build the full execution name without premature truncation - If the name exceeds 63 characters, truncate to 54 characters and append an 8-character SHA256 hash suffix - This guarantees unique names even when truncation is required Closes: OSPRH-26041 Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
jpodivin
left a comment
jpodivin
left a comment
There was a problem hiding this comment.
I like this. It's much better than the solution we originally came up with.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: holser, jpodivin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test openstack-operator-build-deploy-kuttl-4-18 |
|
/test openstack-operator-build-deploy-kuttl-4-18 |
|
@holser: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test openstack-operator-build-deploy-kuttl-4-18 |
3 participants
Previously, when the combined service + deployment + nodeset name exceeded 63 characters (DNS1123 max), simple truncation could cause different jobs to end up with identical names, leading to collisions.
Replace the arbitrary -10 prefix truncation with a hash-based approach:
Closes: OSPRH-26041