Default MetricStorage NetworkAttachments to ctlplane#827
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f39d1351ff2349968c081ab8464f9879 ✔️ openstack-k8s-operators-content-provider SUCCESS in 57m 55s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5d35876c89884b759063abdca1fee62a ✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 25s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8ccff3636cb34d07b2913c8f3e082d69 ✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 53s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2a9e299272f34edc9e9a641abf210883 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 18m 09s |
|
CI issues seem unrelated to the change |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c6ee37a2bfbf41f9bd9e11f1eb695ad9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 56m 55s |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vkmc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for the review Emma! I missed that |
|
Kuttl tests are failing since the NAD required for tests/default is not available When inspecting the logs, I noticed that the user supplied namespace creation is being skipped for all tests. I think this is an issue that should be fixed in a follow up patch. For this PR, I added the NAD creation as a step in default/tests |
vkmc
force-pushed
the
OSPRH-22189/use-dataplane-nw-default-nad
branch
from
66204d4 to
78d50f6
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3d70a6fa7e824443bba7f40e0fa9e467 ❌ openstack-k8s-operators-content-provider FAILURE in 13m 16s |
|
recheck |
|
/retest |
vkmc
force-pushed
the
OSPRH-22189/use-dataplane-nw-default-nad
branch
from
78d50f6 to
90f720d
Compare
|
Testing status of Kuttl tests in main in #836 to understand better the output in this PR For some reason, after adding the NAD in the default test, Prometheus fail to start with an storage issue If we do have a resources issue, this should be happening in main as well. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/41dcda669a0c46b687ddcb124f3c7716 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 50s |
| - script: | | ||
| oc apply -f deps/loki-operator.yaml | ||
| until oc api-resources | grep -q grafana; do sleep 1; done | ||
| - script: oc apply -n telemetry-kuttl-tests -f https://raw.githubusercontent.com/openstack-k8s-operators/infra-operator/main/config/samples/network_v1beta1_netconfig.yaml |
There was a problem hiding this comment.
It seems that you are applying the NetConfig configuration to the wrong namespace. I think that our tests are actually running in telemetry-kuttl-default namespace.
Maybe changing the namespace here fixes the issue you are seeing.
There was a problem hiding this comment.
There was a problem hiding this comment.
Unfortunately didn't do the trick. We set the namespace for kuttl tests in https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/kuttl-test.yaml#L19. The config for individual kuttl tests https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/test/kuttl/tests/default/kuttl-test.yaml#L5 is being skipped (for all tests, we have the lines
=== CONT kuttl/harness/default
logger.go:42: 15:54:16 | default | Ignoring deps as it does not match file name regexp: ^(\d+)-(?:[^\.]+)(?:\.yaml)?$
logger.go:42: 15:54:16 | default | Ignoring kuttl-test.yaml as it does not match file name regexp: ^(\d+)-(?:[^\.]+)(?:\.yaml)?$
logger.go:42: 15:54:16 | default | Ignoring output as it does not match file name regexp: ^(\d+)-(?:[^\.]+)(?:\.yaml)?$
logger.go:42: 15:54:16 | default | Skipping creation of user-supplied namespace: telemetry-kuttl-tests
)
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/42503d098d974bc88be0b8ee96569d17 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 20s |
vkmc
force-pushed
the
OSPRH-22189/use-dataplane-nw-default-nad
branch
from
1910d23 to
52eb95a
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3a27506b34424d0f837764ee830aef99 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 11s |
Updates the MetricStorage CRD to default NetworkAttachments to ["ctlplane"]. This aligns the field with DataplaneNetwork and removes the manual requirement for users to override this in the OpenStackControlPlane CR. Closes: OSPRH-22189
The marker used should be // +kubebuilder:default:={"ctlplane"}
to avoid the generator treating the expresssion as a string literal.
Create the NAD for 'ctlplane' before creating the Telemetry CR This is the new default value for metricStorage NAD, so the metricStorage will fail to start without this CR available
This dep is required to define the NAD used by the MetricStorage
vkmc
force-pushed
the
OSPRH-22189/use-dataplane-nw-default-nad
branch
from
52eb95a to
3e6497e
Compare
|
@vkmc: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/765431f4effc432fa8f960fabe7c370a ✔️ openstack-k8s-operators-content-provider SUCCESS in 33m 52s |
4 participants
Updates the MetricStorage CRD to default NetworkAttachments to ["ctlplane"]. This aligns the field with DataplaneNetwork and removes the manual requirement for users to override this in the OpenStackControlPlane CR.
Closes: OSPRH-22189