Create watcherapi keystone endpoint

[cescgina]

Create the WatcherAPI keystoneEndpoint. After this point, we can run
watcher commands from the openstackclient pod (even though we can't do
anything because the decision engine and applier are not available yet).

This version does not support TLS, so the control plane must be
deployed with TLS disabled as well.

Add tests for WatcherAPI keystoneendpoint addition, and remove specific ip from
watcher-api-service-override, as that can be environment-specific.

Related: OSPRH-11483

Depends-On: openstack-k8s-operators/ci-framework#2658

[abays]

I think you can remove the if block here and just return ctrlResult, nil

[cescgina]

true, good catch, I'll push the change with the updated functional test

[abays]

Suggested change

	return ctrl.Result{}, err
	return result, err

[cescgina]

fixed, will push the fix in the next update

[amoralej]

This version does not support TLS, so the control plane must be deployed with TLS disabled as well.

Note that the fact that the operator does not support creating TLS endpoing does not imply that watcher can not run with a TLS enabled controlplane. Actually, I think we should be able to use a TLS enabled controlplane with #45 even if we are exposing watcher as http only.

[softwarefactory-project-zuul]

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2658 is needed.

[cescgina]

recheck

[softwarefactory-project-zuul]

This change depends on a change with an invalid configuration.

[cescgina]

recheck

[amoralej]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amoralej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [amoralej]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[raukadah]

/lgtm

Kuttl tests are validating it with via running commands in openstackclient pod.

 logger.go:42: 07:52:53 | watcher-api-service-override/1-deploy-with-defaults | + oc exec -n watcher-kuttl-default openstackclient -- openstack service list -f value -c Name -c Type
    logger.go:42: 07:52:53 | watcher-api-service-override/1-deploy-with-defaults | ++ grep -c '^watcher'
    logger.go:42: 07:52:55 | watcher-api-service-override/1-deploy-with-defaults | + '[' 1 == 1 ']'
    logger.go:42: 07:52:55 | watcher-api-service-override/1-deploy-with-defaults | ++ oc exec -n watcher-kuttl-default openstackclient -- openstack service list -f value -c Name -c Type -c ID
    logger.go:42: 07:52:55 | watcher-api-service-override/1-deploy-with-defaults | ++ awk '{print $1}'
    logger.go:42: 07:52:55 | watcher-api-service-override/1-deploy-with-defaults | ++ grep watcher