Skip to content

Fix: enforce singleton patten openstack connection #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paikend merged 2 commits into from
Aug 18, 2025
Merged

Fix: enforce singleton patten openstack connection #44

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ec3fdf
Fix: enforce singleton patten openstack connection
paikend Aug 15, 2025
cb7b285
Remove: connection cleanup(Already support in opsntack SDK)
paikend Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/openstack_mcp_server/tools/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import atexit

import openstack

from openstack import connection
Expand All @@ -10,18 +12,26 @@ class OpenStackConnectionManager:

_connection: connection.Connection | None = None

# TODO: Try/Catch disconnection by token expired case
@classmethod
def get_connection(cls) -> connection.Connection:
"""OpenStack Connection)"""
"""OpenStack Connection"""
if cls._connection is None:
openstack.enable_logging(debug=config.MCP_DEBUG_MODE)
cls._connection = openstack.connect(cloud=config.MCP_CLOUD_NAME)
atexit.register(cls._cleanup)
return cls._connection

# TODO: Close connection
@classmethod
def _cleanup(cls) -> None:
"""Cleanup method called at program exit"""
if cls._connection is not None:
cls._connection.close()
cls._connection = None


_openstack_connection_manager = OpenStackConnectionManager()


def get_openstack_conn():
"""Get OpenStack Connection"""
return OpenStackConnectionManager.get_connection()
return _openstack_connection_manager.get_connection()