Skip to content

Conversation

@choieastsea
Copy link
Collaborator

@choieastsea choieastsea commented Aug 18, 2025

Overview

  • update fastmcp >= 2.11.3
  • remove COM812 linting rule

Related Issues

Additional context

When you run uv run ruff format --check which check ruff linting rules, below wanrings out. Since ruff formatter already do format with its own rule about trailing-comma, formatting can be conflict with linting rule so removed it.

> Run uv run ruff format --check .
warning: The following rule may cause conflicts when used with the formatter: `COM812`. To avoid unexpected behavior, we recommend disabling this rule, either by removing it from the `lint.select` or `lint.extend-select` configuration, or adding it to the `lint.ignore` configuration.

CI, 로컬에서 위와 같은 warning이 나오는데, ruff formatter를 이미 사용하고 있는 경우 COM812(trailing comma) 규칙이 충돌을 일으킬 수 있어 제거하였습니다.

@choieastsea choieastsea self-assigned this Aug 18, 2025
@choieastsea choieastsea added the fix Minor fixes, tweaks, and code improvements label Aug 18, 2025
@choieastsea choieastsea requested review from S0okJu and halucinor and removed request for S0okJu August 18, 2025 14:51
Copy link
Collaborator

@S0okJu S0okJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@halucinor
Copy link
Collaborator

아래 PR 먼저 반영하고 마지막에 넣으시죠

@choieastsea choieastsea merged commit dbae5c3 into develop Aug 18, 2025
6 checks passed
platanus-kr pushed a commit that referenced this pull request Aug 19, 2025
halucinor pushed a commit that referenced this pull request Aug 24, 2025
@halucinor halucinor deleted the chore/update-fastmcp branch August 24, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Minor fixes, tweaks, and code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants