Skip to content

Fix: alignment network model field #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
platanus-kr merged 2 commits into from
Aug 20, 2025
Merged

Fix: alignment network model field #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12983f3
fix(network): alignment network model field (#55)
platanus-kr Aug 20, 2025
e33179f
fix(network): test pass (#55)
platanus-kr Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/openstack_mcp_server/tools/network_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ def _convert_to_network_model(self, openstack_network) -> Network:
name=openstack_network.name or "",
status=openstack_network.status or "",
description=openstack_network.description or None,
is_admin_state_up=openstack_network.admin_state_up or False,
is_shared=openstack_network.shared or False,
is_admin_state_up=openstack_network.is_admin_state_up or False,
is_shared=openstack_network.is_shared or False,
mtu=openstack_network.mtu or None,
provider_network_type=openstack_network.provider_network_type
or None,
Expand Down
44 changes: 22 additions & 22 deletions tests/tools/test_network_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ def test_get_networks_success(
mock_network1.name = "private-network"
mock_network1.status = "ACTIVE"
mock_network1.description = "Private network for project"
mock_network1.admin_state_up = True
mock_network1.shared = False
mock_network1.is_admin_state_up = True
mock_network1.is_shared = False
mock_network1.mtu = 1500
mock_network1.provider_network_type = "vxlan"
mock_network1.provider_physical_network = None
Expand All @@ -38,8 +38,8 @@ def test_get_networks_success(
mock_network2.name = "public-network"
mock_network2.status = "ACTIVE"
mock_network2.description = "Public shared network"
mock_network2.admin_state_up = True
mock_network2.shared = True
mock_network2.is_admin_state_up = True
mock_network2.is_shared = True
mock_network2.mtu = 1450
mock_network2.provider_network_type = "flat"
mock_network2.provider_physical_network = "physnet1"
Expand Down Expand Up @@ -113,8 +113,8 @@ def test_get_networks_with_status_filter(
mock_network1.name = "active-network"
mock_network1.status = "ACTIVE"
mock_network1.description = None
mock_network1.admin_state_up = True
mock_network1.shared = False
mock_network1.is_admin_state_up = True
mock_network1.is_shared = False
mock_network1.mtu = None
mock_network1.provider_network_type = None
mock_network1.provider_physical_network = None
Expand All @@ -126,8 +126,8 @@ def test_get_networks_with_status_filter(
mock_network2.name = "down-network"
mock_network2.status = "DOWN"
mock_network2.description = None
mock_network2.admin_state_up = False
mock_network2.shared = False
mock_network2.is_admin_state_up = False
mock_network2.is_shared = False
mock_network2.mtu = None
mock_network2.provider_network_type = None
mock_network2.provider_physical_network = None
Expand Down Expand Up @@ -160,8 +160,8 @@ def test_get_networks_shared_only(
mock_network1.name = "private-network"
mock_network1.status = "ACTIVE"
mock_network1.description = None
mock_network1.admin_state_up = True
mock_network1.shared = False
mock_network1.is_admin_state_up = True
mock_network1.is_shared = False
mock_network1.mtu = None
mock_network1.provider_network_type = None
mock_network1.provider_physical_network = None
Expand All @@ -173,8 +173,8 @@ def test_get_networks_shared_only(
mock_network2.name = "shared-network"
mock_network2.status = "ACTIVE"
mock_network2.description = None
mock_network2.admin_state_up = True
mock_network2.shared = True
mock_network2.is_admin_state_up = True
mock_network2.is_shared = True
mock_network2.mtu = None
mock_network2.provider_network_type = None
mock_network2.provider_physical_network = None
Expand Down Expand Up @@ -205,8 +205,8 @@ def test_create_network_success(self, mock_openstack_connect_network):
mock_network.name = "new-network"
mock_network.status = "ACTIVE"
mock_network.description = "A new network"
mock_network.admin_state_up = True
mock_network.shared = False
mock_network.is_admin_state_up = True
mock_network.is_shared = False
mock_network.mtu = 1500
mock_network.provider_network_type = "vxlan"
mock_network.provider_physical_network = None
Expand Down Expand Up @@ -260,8 +260,8 @@ def test_create_network_minimal_args(self, mock_openstack_connect_network):
mock_network.name = "minimal-network"
mock_network.status = "ACTIVE"
mock_network.description = None
mock_network.admin_state_up = True
mock_network.shared = False
mock_network.is_admin_state_up = True
mock_network.is_shared = False
mock_network.mtu = None
mock_network.provider_network_type = None
mock_network.provider_physical_network = None
Expand Down Expand Up @@ -307,8 +307,8 @@ def test_get_network_detail_success(self, mock_openstack_connect_network):
mock_network.name = "detail-network"
mock_network.status = "ACTIVE"
mock_network.description = "Network for detail testing"
mock_network.admin_state_up = True
mock_network.shared = True
mock_network.is_admin_state_up = True
mock_network.is_shared = True
mock_network.mtu = 1500
mock_network.provider_network_type = "vlan"
mock_network.provider_physical_network = "physnet1"
Expand Down Expand Up @@ -364,8 +364,8 @@ def test_update_network_success(self, mock_openstack_connect_network):
mock_network.name = "updated-network"
mock_network.status = "ACTIVE"
mock_network.description = "Updated description"
mock_network.admin_state_up = False
mock_network.shared = True
mock_network.is_admin_state_up = False
mock_network.is_shared = True
mock_network.mtu = 1400
mock_network.provider_network_type = "vxlan"
mock_network.provider_physical_network = None
Expand Down Expand Up @@ -422,8 +422,8 @@ def test_update_network_partial_update(
mock_network.name = "new-name"
mock_network.status = "ACTIVE"
mock_network.description = "old description"
mock_network.admin_state_up = True
mock_network.shared = False
mock_network.is_admin_state_up = True
mock_network.is_shared = False
mock_network.mtu = None
mock_network.provider_network_type = None
mock_network.provider_physical_network = None
Expand Down