Skip to content

test: Remove unnecessary 'or []' fallback in assertions #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paikend merged 1 commit into from
Oct 13, 2025
Merged

test: Remove unnecessary 'or []' fallback in assertions #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/tools/test_network_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ def test_add_port_fixed_ip(self, mock_openstack_connect_network):
new_fixed = list(current.fixed_ips)
new_fixed.append({"subnet_id": "subnet-2", "ip_address": "10.0.1.10"})
res = tools.update_port("port-1", fixed_ips=new_fixed)
assert len(res.fixed_ips or []) == 2
assert len(res.fixed_ips) == 2

def test_remove_port_fixed_ip(self, mock_openstack_connect_network):
mock_conn = mock_openstack_connect_network
Expand Down Expand Up @@ -711,7 +711,7 @@ def test_remove_port_fixed_ip(self, mock_openstack_connect_network):
fi for fi in current.fixed_ips if fi["ip_address"] != "10.0.1.10"
]
res = tools.update_port("port-1", fixed_ips=filtered)
assert len(res.fixed_ips or []) == 1
assert len(res.fixed_ips) == 1

def test_get_and_update_allowed_address_pairs(
self,
Expand Down Expand Up @@ -1289,6 +1289,7 @@ def test_update_reassign_bulk_and_auto_assign_floating_ip(
mock_conn.network.create_ip.side_effect = [f1]
bulk = tools.create_floating_ips_bulk("ext-net", 1)
assert len(bulk) == 1
assert bulk[0].id == f1.id

exists = Mock()
exists.id = "fip-b"
Expand Down