Fix logging.info and state transitions in LoggingMachine#3270
Open
ionodeionode wants to merge 2 commits intoopentensor:stagingfrom
Open
Fix logging.info and state transitions in LoggingMachine#3270ionodeionode wants to merge 2 commits intoopentensor:stagingfrom
ionodeionode wants to merge 2 commits intoopentensor:stagingfrom
Conversation
Release/10.1.0
…ved issue opentensor#1836 by explicitly setting logger level and using methods for transitions to ensure state consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1836.
This PR addresses the issue where
logging.infoand other logging levels were not correctly updating the logger level during state transitions.Changes:
self._logger.setLevel()inbefore_enable_info,before_enable_debug, etc.disable_info,disable_debug, etc.) to useself.enable_default()to ensure consistent state reset.before_enable_defaultandbefore_enable_infoto correctly toggleself._stream_formatter.set_trace().Verified with a test script simulating both CLI flag and manual
set_infocalls.