Feat/rework ck swap #792
Open
Feat/rework ck swap #792
+618
−386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap coldkey rework
Reworks the swap-coldkey command based on subtensor changes:
opentensor/subtensor#2251
Note: MeV protection currently not working for execute & reannouncement. Waiting upstream changes before testing again.
Updated commands
1.
btcli swap-coldkey announceImportant
Case: Fresh announcement with no prior records
Important
Case: Reannouncement of the same key
Important
Case: Reannouncement of a different key
Important
Case: Cool-down period before reannouncement can proceed
2.
btcli swap-coldkey executeImportant
Case: Mismatch between recorded hash and provided hash
Important
Case: Matching hash
3.
btcli wallet swap-check