-
Notifications
You must be signed in to change notification settings - Fork 272
Emission-based Neuron Deregistration #2158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/subtensor into refactor-neuron-deregistration
l0r1s
reviewed
Nov 20, 2025
pallets/subtensor/src/migrations/migrate_clear_rank_trust_pruning_maps.rs
Outdated
Show resolved
Hide resolved
pallets/subtensor/src/migrations/migrate_clear_rank_trust_pruning_maps.rs
Outdated
Show resolved
Hide resolved
pallets/subtensor/src/migrations/migrate_clear_rank_trust_pruning_maps.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Loris Moulin <45130584+l0r1s@users.noreply.github.com>
Comment on lines
+522
to
+523
| let min_free: u16 = Self::get_min_non_immune_uids(netuid); | ||
| let can_prune_non_immune = free_count > min_free; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l0r1s
approved these changes
Dec 12, 2025
sam0x17
approved these changes
Dec 12, 2025
gztensor
approved these changes
Dec 12, 2025
|
backwards compatibility? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
trust,rankandpruning_scoreand instead selects a neuron for deregistration based onimmunity,emission,reg_block, and thenuidRelated Issue(s)
Fix neuron pruning #1903
Set a minimum number of non-immune, non-immortal UIDs per (sub)subnet #2058