fix: remove duplicate safe_exp function, use exp_safe instead #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
sam0x17
added
the
skip-cargo-audit
Contributor
|
@MkDev11 , thank you for your contribution. While the functions are not exactly the same, the argument range of |
gztensor
previously approved these changes
Dec 16, 2025
Contributor
Author
|
@sam0x17 Please check the PR when you are available. |
Contributor
|
CI failing |
Resolves opentensor#2149 The codebase had two similar exponentiation functions: - exp_safe (line 172): Robust implementation with input clamping [-20, 20] and smart error handling (returns max_value for positive overflow) - safe_exp (line 1597): Simple wrapper returning 0 on any error This commit: - Removes the duplicate safe_exp function from math.rs - Updates run_epoch.rs to use exp_safe instead exp_safe is the better choice as it: 1. Clamps input to prevent overflow in the first place 2. Returns max_value (not 0) when large positive inputs overflow 3. Has existing test coverage in tests/math.rs
MkDev11
force-pushed
the
fix/remove-duplicate-exp-functions
branch
from
f5033de to
daf6ad8
Compare
Contributor
Author
|
@sam0x17 Can you check again? |
Contributor
Author
|
@gztensor Can you approve the PR again? I changed the base branch from |
sam0x17
approved these changes
Dec 18, 2025
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2149
Problem
The codebase has two similar exponentiation functions in
math.rs:exp_safe(line 172): Robust implementation with:max_valuefor positive overflow, 0 for negative)tests/math.rssafe_exp(line 1597): Simple wrapper that:Solution
safe_expfunction frommath.rsrun_epoch.rsto useexp_safeinsteadWhy
exp_safeis bettermax_value(not 0) when large positive inputs would overflow - more mathematically correctTesting
cargo check -p pallet-subtensorpassesexp_safetests intests/math.rsprovide coverageContribution by Gittensor, learn more at https://gittensor.io/