Skip to content

Conversation

@camfairchild
Copy link
Contributor

Description

Fixes and issue in the recycle_alpha and burn_alpha calls where we may recycle/burn more than the intended amount.
We add an ensure and Error::<T>::PrecisionLoss for the decrease_stake_* call.

Also adds tests for this.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

Contribution by Gittensor, learn more at https://gittensor.io/

sam0x17
sam0x17 previously approved these changes Dec 16, 2025
@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Dec 19, 2025
@sam0x17 sam0x17 merged commit be47139 into opentensor:devnet-ready Dec 19, 2025
167 of 175 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants