Skip to content

Conversation

@ales-otf
Copy link
Contributor

@ales-otf ales-otf commented Dec 29, 2025

Description

In our EVM precompiles we use substrate's Dispatchable::dispatch API that is basically a method call (https://docs.rs/sp-runtime/latest/sp_runtime/traits/trait.Dispatchable.html). It means unlike with extrinsic pipeline, things like validation and transaction extensions are ignored. This PR manually triggers SubtensorTransactionExtension lifecycle API to enforce transaction extension. It's done in PrecompileHandleExt::try_dispatch_runtime_call - the method we use to dispatch calls in contracts.

I've also added ts-node options to the contracts E2E run command to fix running the tests locally.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@ales-otf ales-otf added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants